add copy for all mutable data structures, address comments

Author: bobzhang

jscomp/others/bs_HashMap.mli

@@ -57,20 +57,13 @@ val remove:
   ('a, 'b, 'id) t
 
 val forEach: ('a, 'b, 'id) t -> ('a -> 'b -> unit [@bs]) -> unit
-(** [Hashtbl.iter f tbl] applies [f] to all bindings in table [tbl].
+(** [forEach tbl f] applies [f] to all bindings in table [tbl].
     [f] receives the key as first argument, and the associated value
     as second argument. Each binding is presented exactly once to [f].
 
-    The order in which the bindings are passed to [f] is unspecified.
-    However, if the table contains several bindings for the same key,
-    they are passed to [f] in reverse order of introduction, that is,
-    the most recent binding is passed first.
-
     If the hash table was created in non-randomized mode, the order
     in which the bindings are enumerated is reproducible between
-    successive runs of the program, and even between minor versions
-    of OCaml.  For randomized hash tables, the order of enumeration
-    is entirely random. *)
+    successive runs of the program. *)
 
 
 val reduce: ('a, 'b, 'id) t -> 'c -> ('c -> 'a -> 'b ->  'c [@bs]) ->  'c

jscomp/others/bs_SetIntM.ml

@@ -336,3 +336,5 @@ let union (dataa : t)  (datab : t) : t =
       t ~data:(N.ofSortedArrayAux tmp2 0 k) 
 
 let has d x = I.mem (data d) x 
+
+let copy d = t ~data:(N.copy (data d)) 

jscomp/others/bs_SetIntM.mli

@@ -31,7 +31,8 @@ type t
 val empty: unit -> t
 val singleton: elt -> t  
 val ofArray: elt array -> t
-val ofSortedArrayUnsafe: elt array -> t   
+val ofSortedArrayUnsafe: elt array -> t
+val copy: t -> t 
 val isEmpty: t -> bool
 val has: t -> elt -> bool
 

jscomp/others/bs_SetM.ml

@@ -353,3 +353,4 @@ let union (type elt) (type id) (a : (elt,id) t) b =
       let k = S.union tmp 0 sizea tmp sizea sizeb tmp2 0 p in 
       B.bag ~data:(N.ofSortedArrayAux tmp2 0 k) ~dict 
 
+let copy d = B.bag ~data:(N.copy (B.data d)) ~dict:(B.dict d)

jscomp/others/bs_SetM.mli

@@ -30,7 +30,7 @@ val empty: dict:('elt, 'id) Bs_Cmp.t -> ('elt, 'id) t
 val singleton: 'elt -> dict:('elt,'id) Bs_Cmp.t ->  ('elt, 'id) t    
 val ofArray: 'k array -> dict:('k, 'id) Bs_Cmp.t ->   ('k, 'id) t
 val ofSortedArrayUnsafe: 'elt array -> dict:('elt, 'id) Bs_Cmp.t ->  ('elt,'id) t
-    
+val copy: ('k, 'id) t -> ('k, 'id) t     
 val isEmpty: _ t -> bool
 val has:  ('elt, _) t -> 'elt ->  bool
 

jscomp/others/bs_SetStringM.ml

@@ -336,3 +336,5 @@ let union (dataa : t)  (datab : t) : t =
       t ~data:(N.ofSortedArrayAux tmp2 0 k) 
 
 let has d x = I.mem (data d) x 
+
+let copy d = t ~data:(N.copy (data d)) 

jscomp/others/bs_SetStringM.mli

@@ -31,7 +31,8 @@ type t
 val empty: unit -> t
 val singleton: elt -> t  
 val ofArray: elt array -> t
-val ofSortedArrayUnsafe: elt array -> t   
+val ofSortedArrayUnsafe: elt array -> t
+val copy: t -> t 
 val isEmpty: t -> bool
 val has: t -> elt -> bool
 

jscomp/others/setm.cppo.ml

@@ -341,3 +341,5 @@ let union (dataa : t)  (datab : t) : t =
       t ~data:(N.ofSortedArrayAux tmp2 0 k) 
 
 let has d x = I.mem (data d) x 
+
+let copy d = t ~data:(N.copy (data d)) 

jscomp/others/setm.cppo.mli

@@ -34,7 +34,8 @@ type t
 val empty: unit -> t
 val singleton: elt -> t  
 val ofArray: elt array -> t
-val ofSortedArrayUnsafe: elt array -> t   
+val ofSortedArrayUnsafe: elt array -> t
+val copy: t -> t 
 val isEmpty: t -> bool
 val has: t -> elt -> bool
 

lib/js/bs_SetIntM.js

@@ -490,10 +490,17 @@ function has(d, x) {
   return Bs_internalSetInt.mem(d.data, x);
 }
 
+function copy(d) {
+  return {
+          data: Bs_internalAVLset.copy(d.data)
+        };
+}
+
 exports.empty = empty;
 exports.singleton = singleton;
 exports.ofArray = ofArray;
 exports.ofSortedArrayUnsafe = ofSortedArrayUnsafe;
+exports.copy = copy;
 exports.isEmpty = isEmpty;
 exports.has = has;
 exports.addDone = addDone;

lib/js/bs_SetM.js

@@ -535,10 +535,18 @@ function union(a, b) {
   }
 }
 
+function copy(d) {
+  return {
+          dict: d.dict,
+          data: Bs_internalAVLset.copy(d.data)
+        };
+}
+
 exports.empty = empty;
 exports.singleton = singleton;
 exports.ofArray = ofArray;
 exports.ofSortedArrayUnsafe = ofSortedArrayUnsafe;
+exports.copy = copy;
 exports.isEmpty = isEmpty;
 exports.has = has;
 exports.addDone = addDone;

lib/js/bs_SetStringM.js

@@ -490,10 +490,17 @@ function has(d, x) {
   return Bs_internalSetString.mem(d.data, x);
 }
 
+function copy(d) {
+  return {
+          data: Bs_internalAVLset.copy(d.data)
+        };
+}
+
 exports.empty = empty;
 exports.singleton = singleton;
 exports.ofArray = ofArray;
 exports.ofSortedArrayUnsafe = ofSortedArrayUnsafe;
+exports.copy = copy;
 exports.isEmpty = isEmpty;
 exports.has = has;
 exports.addDone = addDone;