Skip to content

Commit c634719

Browse files
authored
drop Node.js v16 (EoL) support (rescript-lang#6429)
* drop Node.js v16 (EoL) support * add CHANGELOG
1 parent 3f1f1e6 commit c634719

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

.github/workflows/ci.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ jobs:
8282
- name: Use Node.js
8383
uses: actions/setup-node@v4
8484
with:
85-
node-version: 16
85+
node-version: 18
8686

8787
- name: Copy exes to platform bin dirs
8888
run: node ./scripts/copyExes.js
@@ -169,7 +169,7 @@ jobs:
169169
- name: Use Node.js
170170
uses: actions/setup-node@v4
171171
with:
172-
node-version: 16
172+
node-version: 18
173173

174174
- name: Install npm packages
175175
run: npm ci --ignore-scripts
@@ -279,7 +279,7 @@ jobs:
279279
- name: Use Node.js
280280
uses: actions/setup-node@v4
281281
with:
282-
node-version: 16
282+
node-version: 18
283283

284284
- name: NPM install
285285
run: npm ci --ignore-scripts
@@ -340,7 +340,7 @@ jobs:
340340
- name: Use Node.js
341341
uses: actions/setup-node@v4
342342
with:
343-
node-version: 16
343+
node-version: 18
344344

345345
- name: Download artifacts
346346
uses: actions/download-artifact@v4
@@ -372,7 +372,7 @@ jobs:
372372
- name: Use Node.js
373373
uses: actions/setup-node@v4
374374
with:
375-
node-version: 16
375+
node-version: 18
376376
registry-url: https://registry.npmjs.org # Needed to make auth work for publishing
377377

378378
- name: Download artifacts

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
- `lazy` syntax is no longer supported. If you're using it, use `Lazy` module or `React.lazy_` instead. https://github.com/rescript-lang/rescript-compiler/pull/6342
1818
- Remove handling of attributes with `bs.` prefix (`@bs.as` -> `@as` etc.). https://github.com/rescript-lang/rescript-compiler/pull/6643
1919
- Remove obsolete `@bs.open` feature. https://github.com/rescript-lang/rescript-compiler/pull/6629
20+
- Drop Node.js version <18 support, due to it reaching End-of-Life. https://github.com/rescript-lang/rescript-compiler/pull/6429
2021

2122
#### :house: Internal
2223

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Happy hacking!
1414

1515
> Most of our contributors are working on Apple machines, so all our instructions are currently macOS / Linux centric. Contributions for Windows development welcome!
1616
17-
- [NodeJS v16](https://nodejs.org/)
17+
- [NodeJS v18](https://nodejs.org/)
1818
- C compiler toolchain (usually installed with `xcode` on Mac)
1919
- `opam` (OCaml Package Manager)
2020
- VSCode (+ [OCaml Platform Extension](https://marketplace.visualstudio.com/items?itemName=ocamllabs.ocaml-platform))

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"prettier": "2.7.1"
88
},
99
"engines": {
10-
"node": ">=10"
10+
"node": ">=18"
1111
},
1212
"bin": {
1313
"bsc": "bsc",

0 commit comments

Comments
 (0)