Skip to content

Commit 9870370

Browse files
authored
CI: reactivate macos-arm builds (rescript-lang#6114)
1 parent fae27f7 commit 9870370

File tree

6 files changed

+11
-12
lines changed

6 files changed

+11
-12
lines changed

.github/workflows/ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ jobs:
104104
strategy:
105105
fail-fast: false
106106
matrix:
107-
# os: [macos-latest, ubuntu-latest, windows-latest, macos-arm]
108-
os: [macos-latest, ubuntu-latest, windows-latest]
107+
os: [macos-latest, ubuntu-latest, windows-latest, macos-arm]
109108
ocaml_compiler: [4.14.0]
110109

111110
runs-on: ${{matrix.os}}
@@ -288,9 +287,10 @@ jobs:
288287
strategy:
289288
fail-fast: false
290289
matrix:
291-
os: [
290+
os:
291+
[
292292
macos-latest,
293-
# macos-arm,
293+
macos-arm,
294294
ubuntu-latest,
295295
buildjet-2vcpu-ubuntu-2204-arm,
296296
windows-latest,

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"bsc",
3030
"rescript",
3131
"darwin",
32+
"darwinarm64",
3233
"linux",
3334
"linuxarm64",
3435
"win32",

packages/artifacts.txt

+4
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ darwin/bsb_helper.exe
99
darwin/bsc.exe
1010
darwin/ninja.exe
1111
darwin/rescript.exe
12+
darwinarm64/bsb_helper.exe
13+
darwinarm64/bsc.exe
14+
darwinarm64/ninja.exe
15+
darwinarm64/rescript.exe
1216
docs/docson/build-schema.json
1317
lib/bstracing
1418
lib/cmi_cache.bin

scripts/bin_path.js

-5
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ var path = require("path");
1212
var binDirName =
1313
process.arch === "x64" ? process.platform : process.platform + process.arch;
1414

15-
// Deactivate support for macos-arm for now
16-
if (binDirName === "darwinarm64") {
17-
binDirName = "darwin";
18-
}
19-
2015
/**
2116
*
2217
* @type{string}

scripts/makeArtifactList.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ if (isCheckMode) {
4646
}
4747

4848
function getFilesAddedByCI() {
49-
// const platforms = ["darwin", "darwinarm64", "linux", "win32"];
50-
const platforms = ["darwin", "linux", "win32"];
49+
const platforms = ["darwin", "darwinarm64", "linux", "win32"];
5150
const exes = ["bsb_helper.exe", "bsc.exe", "ninja.exe", "rescript.exe"];
5251

5352
const files = ["ninja.COPYING"];

scripts/moveArtifacts.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -e
44
chmod +x binaries-*/*.exe
55

66
mv binaries-darwin darwin
7-
# mv binaries-darwinarm64 darwinarm64
7+
mv binaries-darwinarm64 darwinarm64
88
mv binaries-linux linux
99
mv binaries-linuxarm64 linuxarm64
1010
mv binaries-win32 win32

0 commit comments

Comments
 (0)