Skip to content

Commit 97e4165

Browse files
committedJun 21, 2018
simplify a little bit, rename Pis_none to Pis_not_none
1 parent b720eca commit 97e4165

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+898
-895
lines changed
 

‎jscomp/core/js_exp_make.ml

+3
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,9 @@ let rec triple_equal ?comment (e0 : t) (e1 : t ) : t =
531531
| Undefined, Null -> caml_false
532532
| Null, Null
533533
| Undefined, Undefined -> caml_true
534+
(* FIXME - this will change after we change the representation*)
535+
| (Number _ | Undefined), Optional_block _
536+
| Optional_block _, (Number _ | Undefined)-> caml_false
534537
| _ ->
535538
{expression_desc = Bin(EqEqEq, e0,e1); comment}
536539

‎jscomp/core/js_of_lam_option.ml

+3-2
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,9 @@ let destruct_optional
108108
let none : J.expression =
109109
{expression_desc = Number (Int {i = 0l; c = None}); comment = Some "None" }
110110

111-
(* let is_not_none (e : J.expression) : J.expression = *)
112-
111+
let is_not_none (e : J.expression) : J.expression =
112+
E.not (E.triple_equal e none)
113+
113114

114115
let some = E.optional_block
115116

0 commit comments

Comments
 (0)