Skip to content

Commit 03ac9bf

Browse files
bobzhangbobzhang
committed
remove uselesss "array" comments
only highlight compiler generated array block (we need such test cases)
1 parent 4774094 commit 03ac9bf

File tree

134 files changed

+1380
-1364
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

134 files changed

+1380
-1364
lines changed

‎jscomp/core/js_of_lam_array.ml

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ module E = Js_exp_make
5656

5757
(* Parrayref(u|s) *)
5858
let make_array mt args =
59-
E.array ~comment:"array" mt args
59+
E.array mt args
6060

6161
let set_array e e0 e1 =
6262
E.assign (E.array_index e e0) e1

‎jscomp/core/lam_compile_util.ml

+5-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,11 @@ let comment_of_tag_info (x : Lam_tag_info.t) =
5151
| Blk_record_inlined (_,ctor,_) -> Some ctor
5252
| Blk_record_ext _ -> None
5353
#end
54-
| Blk_array -> Some "array"
54+
| Blk_array ->
55+
(* so far only appears in {!Translclass}
56+
and some constant immutable array block
57+
*)
58+
Some "array"
5559
| Blk_module_export
5660
| Blk_module _ ->
5761
(* Turn it on next time to save some noise diff*)

‎jscomp/test/a_filename_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ eq("File \"a_filename_test.ml\", line 64, characters 5-12", Ext_filename_test.ge
106106

107107
eq("File \"a_filename_test.ml\", line 68, characters 5-12", Ext_filename_test.get_extension(".txt"), ".txt");
108108

109-
eq("File \"a_filename_test.ml\", line 73, characters 5-12", $$Array.map(Ext_filename_test.normalize_absolute_path, /* array */[
109+
eq("File \"a_filename_test.ml\", line 73, characters 5-12", $$Array.map(Ext_filename_test.normalize_absolute_path, [
110110
"/gsho/./..",
111111
"/a/b/../c../d/e/f",
112112
"/a/b/../c/../d/e/f",
@@ -117,7 +117,7 @@ eq("File \"a_filename_test.ml\", line 73, characters 5-12", $$Array.map(Ext_file
117117
"/a",
118118
"/a.txt/",
119119
"/a.txt"
120-
]), /* array */[
120+
]), [
121121
"/",
122122
"/a/c../d/e/f",
123123
"/a/d/e/f",

‎jscomp/test/arith_parser.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var Block = require("../../lib/js/block.js");
44
var Parsing = require("../../lib/js/parsing.js");
55
var Caml_builtin_exceptions = require("../../lib/js/caml_builtin_exceptions.js");
66

7-
var yytransl_const = /* array */[
7+
var yytransl_const = [
88
259,
99
260,
1010
261,
@@ -16,7 +16,7 @@ var yytransl_const = /* array */[
1616
0
1717
];
1818

19-
var yytransl_block = /* array */[
19+
var yytransl_block = [
2020
257,
2121
258,
2222
0
@@ -44,7 +44,7 @@ var yynames_const = "PLUS\0MINUS\0TIMES\0DIVIDE\0UMINUS\0LPAREN\0RPAREN\0EOF\0";
4444

4545
var yynames_block = "NUMERAL\0IDENT\0";
4646

47-
var yyact = /* array */[
47+
var yyact = [
4848
(function (param) {
4949
throw [
5050
Caml_builtin_exceptions.failure,

‎jscomp/test/array_safe_get.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var Caml_array = require("../../lib/js/caml_array.js");
44
var Caml_js_exceptions = require("../../lib/js/caml_js_exceptions.js");
55
var Caml_builtin_exceptions = require("../../lib/js/caml_builtin_exceptions.js");
66

7-
var x = /* array */[
7+
var x = [
88
1,
99
2
1010
];

‎jscomp/test/array_subtle_test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function eq(loc, param) {
3131
return /* () */0;
3232
}
3333

34-
var v = /* array */[
34+
var v = [
3535
1,
3636
2,
3737
3,
@@ -116,17 +116,17 @@ function fff4(x) {
116116
}
117117

118118
eq("File \"array_subtle_test.ml\", line 51, characters 6-13", /* tuple */[
119-
fff3(/* array */[]),
119+
fff3([]),
120120
1
121121
]);
122122

123123
eq("File \"array_subtle_test.ml\", line 52, characters 6-13", /* tuple */[
124-
fff4(/* array */[]),
124+
fff4([]),
125125
2
126126
]);
127127

128128
eq("File \"array_subtle_test.ml\", line 53, characters 6-13", /* tuple */[
129-
fff4(/* array */[1]),
129+
fff4([1]),
130130
1
131131
]);
132132

‎jscomp/test/array_test.js

+17-17
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ var array_suites_000 = /* tuple */[
5959
$$Array.init(5, (function (x) {
6060
return x;
6161
})),
62-
/* array */[
62+
[
6363
0,
6464
1,
6565
2,
@@ -87,7 +87,7 @@ var array_suites_001 = /* :: */[
8787
};
8888
var match = List.split(aux(/* :: */[
8989
/* tuple */[
90-
/* array */[],
90+
[],
9191
/* [] */0
9292
],
9393
/* [] */0
@@ -103,7 +103,7 @@ var array_suites_001 = /* :: */[
103103
"concat",
104104
(function (param) {
105105
return /* Eq */Block.__(0, [
106-
/* array */[
106+
[
107107
0,
108108
1,
109109
2,
@@ -112,20 +112,20 @@ var array_suites_001 = /* :: */[
112112
5
113113
],
114114
Caml_array.caml_array_concat(/* :: */[
115-
/* array */[
115+
[
116116
0,
117117
1,
118118
2
119119
],
120120
/* :: */[
121-
/* array */[
121+
[
122122
3,
123123
4
124124
],
125125
/* :: */[
126-
/* array */[],
126+
[],
127127
/* :: */[
128-
/* array */[5],
128+
[5],
129129
/* [] */0
130130
]
131131
]
@@ -159,14 +159,14 @@ var array_suites_001 = /* :: */[
159159
"sub",
160160
(function (param) {
161161
return /* Eq */Block.__(0, [
162-
$$Array.sub(/* array */[
162+
$$Array.sub([
163163
0,
164164
1,
165165
2,
166166
3,
167167
4
168168
], 2, 2),
169-
/* array */[
169+
[
170170
2,
171171
3
172172
]
@@ -177,7 +177,7 @@ var array_suites_001 = /* :: */[
177177
/* tuple */[
178178
"blit",
179179
(function (param) {
180-
var u = /* array */[
180+
var u = [
181181
100,
182182
0,
183183
0
@@ -188,12 +188,12 @@ var array_suites_001 = /* :: */[
188188
$$Array.blit(v, 1, u, 1, 2);
189189
return /* Eq */Block.__(0, [
190190
/* tuple */[
191-
/* array */[
191+
[
192192
0,
193193
2,
194194
4
195195
],
196-
/* array */[
196+
[
197197
100,
198198
2,
199199
4
@@ -216,7 +216,7 @@ var array_suites_001 = /* :: */[
216216
$$Array.blit(a0, 10, a0, 5, 20);
217217
return /* Eq */Block.__(0, [
218218
true,
219-
starts_with(a0, /* array */[
219+
starts_with(a0, [
220220
0,
221221
1,
222222
2,
@@ -257,7 +257,7 @@ var array_suites_001 = /* :: */[
257257
$$Array.blit(a0, 5, a0, 10, 20);
258258
return /* Eq */Block.__(0, [
259259
true,
260-
starts_with(a0, /* array */[
260+
starts_with(a0, [
261261
0,
262262
1,
263263
2,
@@ -296,7 +296,7 @@ var array_suites_001 = /* :: */[
296296
(function (param) {
297297
return /* Eq */Block.__(0, [
298298
Caml_array.caml_make_vect(2, 1),
299-
/* array */[
299+
[
300300
1,
301301
1
302302
]
@@ -307,14 +307,14 @@ var array_suites_001 = /* :: */[
307307
/* tuple */[
308308
"sort",
309309
(function (param) {
310-
var u = /* array */[
310+
var u = [
311311
3,
312312
0,
313313
1
314314
];
315315
$$Array.sort(Caml_primitive.caml_int_compare, u);
316316
return /* Eq */Block.__(0, [
317-
Caml_obj.caml_equal(/* array */[
317+
Caml_obj.caml_equal([
318318
0,
319319
1,
320320
3

‎jscomp/test/ast_abstract_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ var v1 = {
5757
z: ""
5858
};
5959

60-
var jsMapperConstantArray = /* array */[
60+
var jsMapperConstantArray = [
6161
/* tuple */[
6262
97,
6363
"a"
@@ -94,7 +94,7 @@ idx(/* b */98);
9494

9595
idx(/* c */99);
9696

97-
var jsMapperConstantArray$1 = /* array */[
97+
var jsMapperConstantArray$1 = [
9898
0,
9999
3,
100100
4

0 commit comments

Comments
 (0)