Add test for installing overcommit

After fixing an issue with installing overcommit hooks in a repo with
hooks installed via template directory in 6d6f853, we add some tests to
ensure we don't break this in future.

Change-Id: Ic3f31ecc288d1273ef17d3c9e7e12d97e72e0781
Reviewed-on: http://gerrit.causes.com/45271
Tested-by: jenkins <jenkins@brigade.com>
Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>

Author: sds

lib/overcommit/installer.rb

@@ -3,8 +3,8 @@
 module Overcommit
   # Manages the installation of Overcommit hooks in a git repository.
   class Installer # rubocop:disable ClassLength
-    MASTER_HOOK =
-      File.join(OVERCOMMIT_HOME, 'template-dir', 'hooks', 'overcommit-hook')
+    TEMPLATE_DIRECTORY = File.join(OVERCOMMIT_HOME, 'template-dir')
+    MASTER_HOOK = File.join(TEMPLATE_DIRECTORY, 'hooks', 'overcommit-hook')
 
     def initialize(logger)
       @log = logger

spec/integration/installing_overcommit_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe 'installing Overcommit' do
+  context 'when template directory points to the Overcommit template directory' do
+    around do |example|
+      repo(:template_dir => Overcommit::Installer::TEMPLATE_DIRECTORY) do
+        example.run
+      end
+    end
+
+    it 'automatically installs Overcommit hooks for new repositories' do
+      Overcommit::Utils.supported_hook_types.each do |hook_type|
+        hook_file = File.join('.git', 'hooks', hook_type)
+        File.read(hook_file).should include 'OVERCOMMIT'
+      end
+    end
+
+    context 'and Overcommit is manually installed' do
+      before do
+        `overcommit --install`
+      end
+
+      it 'replaces the hooks with symlinks' do
+        Overcommit::Utils.supported_hook_types.each do |hook_type|
+          hook_file = File.join('.git', 'hooks', hook_type)
+          File.symlink?(hook_file).should == true
+        end
+      end
+    end
+  end
+end

spec/support/git_spec_helpers.rb

@@ -4,11 +4,11 @@
 module GitSpecHelpers
   module_function
 
-  def repo(name = 'some-repo', &block)
-    directory(name) do
-      `git init --template=""` # Ensure no template directory is applied
+  def repo(options = {}, &block)
+    directory('some-repo') do
+      `git init --template="#{options[:template_dir]}"`
 
-      `mkdir -p .git/hooks` # Since we don't specify template, need to create ourselves
+      `mkdir -p .git/hooks` # Since we may not specify template, need to create ourselves
 
       # Need to define user info since some CI contexts don't have defaults set
       `git config --local user.name "Overcommit Tester"`