Extract `Reporter' class

Slimming down classes, separating concerns. Next step is to get all
'puts'-ing out of the GitHook class.

Change-Id: I21b91f4a7c020e33354c197f75d97c9611061d05
Reviewed-on: https://gerrit.causes.com/22363
Tested-by: Aiden Scandella <aiden@causes.com>
Reviewed-by: Shane da Silva <shane@causes.com>

Author: Aiden Scandella

lib/overcommit.rb

@@ -3,5 +3,6 @@
 require 'overcommit/git_hook'
 require 'overcommit/hook_specific_check'
 require 'overcommit/staged_file'
+require 'overcommit/reporter'
 require 'overcommit/utils'
 require 'overcommit/version'

lib/overcommit/git_hook.rb

@@ -33,7 +33,7 @@ def initialize
         plugin_dirs << REPO_SPECIFIC_DIR if File.directory?(REPO_SPECIFIC_DIR)
 
         plugin_dirs.each do |dir|
-          Dir[File.join(dir, hook_name, '*.rb')].each do |plugin|
+          Dir[File.join(dir, Overcommit::Utils.hook_name, '*.rb')].each do |plugin|
             unless skip_checks.include? File.basename(plugin, '.rb')
               begin
                 require plugin
@@ -44,14 +44,15 @@ def initialize
             end
           end
         end
-
-        @width = 70 - (HookRegistry.checks.map { |s| s.name.length }.max || 0)
       end
 
       def run(*args)
         exit if requires_modified_files? && modified_files.empty?
 
-        puts "Running #{hook_name} checks"
+        reporter = Reporter.new(Overcommit::Utils.hook_name, HookRegistry.checks)
+
+        reporter.print_header
+
         results = HookRegistry.checks.map do |check_class|
           check = check_class.new(*args)
           next if check.skip?
@@ -65,76 +66,19 @@ def run(*args)
 
           status, output = check.run_check
 
-          print_incremental_result(title, status, output, check.stealth?)
+          reporter.print_incremental_result(title, status, output, check.stealth?)
           [status, output]
         end.compact
 
-        print_result results
-      end
-
-      def hook_name
-        Overcommit::Utils.hook_name
+        reporter.print_result results
       end
 
-    protected
+    private
 
       # If true, only run this check when there are modified files.
       def requires_modified_files?
         false
       end
-
-      def print_incremental_result(title, status, output, stealth = false)
-        if stealth
-          return if status == :good
-          print title
-        end
-
-        print '.' * (@width - title.length)
-        case status
-        when :good
-          success('OK')
-        when :bad
-          error('FAILED')
-          print_report(output)
-        when :warn
-          warning output
-        when :stop
-          warning 'UH OH'
-          print_report(output)
-        else
-          error '???'
-          print_report("Check didn't return a status")
-          exit 1
-        end
-      end
-
-      def print_result(results)
-        puts
-        case final_result(results)
-        when :good
-          success "+++ All #{hook_name} checks passed"
-          exit 0
-        when :bad
-          error "!!! One or more #{hook_name} checks failed"
-          exit 1
-        when :stop
-          warning "*** One or more #{hook_name} checks needs attention"
-          warning "*** If you really want to commit, use SKIP_CHECKS"
-          warning "*** (takes a space-separated list of checks to skip, or 'all')"
-          exit 1
-        end
-      end
-
-      def final_result(results)
-        states = (results.transpose.first || []).uniq
-        return :bad  if states.include?(:bad)
-        return :stop if states.include?(:stop)
-        return :good
-      end
-
-      def print_report(*report)
-        puts report.flatten.map{ |line| "    #{line}" }.join("\n")
-      end
     end
   end
 end

lib/overcommit/reporter.rb

@@ -0,0 +1,70 @@
+module Overcommit
+  class Reporter
+    include ConsoleMethods
+
+    def initialize(name, checks)
+      @name   = name
+      @checks = checks
+      @width  = 70 - (@checks.map { |s| s.name.length }.max || 0)
+    end
+
+    def print_header
+      puts "Running #{@name} checks"
+    end
+
+    def print_incremental_result(title, status, output, stealth = false)
+      if stealth
+        return if status == :good
+        print title
+      end
+
+      print '.' * (@width - title.length)
+      case status
+      when :good
+        success('OK')
+      when :bad
+        error('FAILED')
+        print_report(output)
+      when :warn
+        warning output
+      when :stop
+        warning 'UH OH'
+        print_report(output)
+      else
+        error '???'
+        print_report("Check didn't return a status")
+        exit 1
+      end
+    end
+
+    def print_result(results)
+      puts
+      case final_result(results)
+      when :good
+        success "+++ All #{@name} checks passed"
+        exit 0
+      when :bad
+        error "!!! One or more #{@name} checks failed"
+        exit 1
+      when :stop
+        warning "*** One or more #{@name} checks needs attention"
+        warning "*** If you really want to commit, use SKIP_CHECKS"
+        warning "*** (takes a space-separated list of checks to skip, or 'all')"
+        exit 1
+      end
+    end
+
+  private
+
+    def final_result(results)
+      states = (results.transpose.first || []).uniq
+      return :bad  if states.include?(:bad)
+      return :stop if states.include?(:stop)
+      return :good
+    end
+
+    def print_report(*report)
+      puts report.flatten.map{ |line| "    #{line}" }.join("\n")
+    end
+  end
+end