From 41c0ea8b9a6498e4cf2d967b55ac09457f863a0a Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Fri, 14 Oct 2022 18:15:05 +0530 Subject: [PATCH 1/2] refactor: move flake8 config --- .flake8 | 5 +++++ .pre-commit-config.yaml | 6 +----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.flake8 b/.flake8 index 9a5863c9cd0b..0d9ef18d142b 100644 --- a/.flake8 +++ b/.flake8 @@ -1,3 +1,8 @@ [flake8] +max-line-length = 88 +max-complexity = 25 extend-ignore = A003 # Class attribute is shadowing a python builtin + # Formatting style for `black` + E203 # Whitespace before ':' + W503 # Line break occurred before a binary operator diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index d2558b90abb1..5b4cbc041e37 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -36,10 +36,6 @@ repos: rev: 5.0.4 hooks: - id: flake8 - args: - - --ignore=E203,W503 - - --max-complexity=25 - - --max-line-length=88 additional_dependencies: - flake8-bugbear - flake8-builtins @@ -51,7 +47,7 @@ repos: - id: mypy args: - --ignore-missing-imports - - --install-types # See mirrors-mypy README.md + - --install-types # See mirrors-mypy README.md - --non-interactive additional_dependencies: [types-requests] From 79553688ff285b9dd943f96d3f54b31a06afcd1f Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Fri, 14 Oct 2022 16:33:48 +0200 Subject: [PATCH 2/2] Update .pre-commit-config.yaml --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 5b4cbc041e37..d3ea9722f8f3 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -35,7 +35,7 @@ repos: - repo: https://github.com/PyCQA/flake8 rev: 5.0.4 hooks: - - id: flake8 + - id: flake8 # See .flake8 for args additional_dependencies: - flake8-bugbear - flake8-builtins