From e1ecd471d941722371b2a94fc0c4683695b75169 Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Fri, 21 May 2021 19:09:44 +0530 Subject: [PATCH 1/6] fix(action): testing and fixing errors --- .github/workflows/approve_workflow_run.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/approve_workflow_run.yml b/.github/workflows/approve_workflow_run.yml index ff6ebd99653e..fcf1c4e1441a 100644 --- a/.github/workflows/approve_workflow_run.yml +++ b/.github/workflows/approve_workflow_run.yml @@ -4,8 +4,6 @@ name: "Approve Workflow Run" on: workflow_run: - types: - - completed jobs: approve: From 3d4ed6f348ba27b0a188bfcf1559187d84da203d Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Fri, 21 May 2021 19:11:16 +0530 Subject: [PATCH 2/6] fix: testing if all is a valid entry for workflows --- .github/workflows/approve_workflow_run.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/approve_workflow_run.yml b/.github/workflows/approve_workflow_run.yml index fcf1c4e1441a..c74a2a0aeca2 100644 --- a/.github/workflows/approve_workflow_run.yml +++ b/.github/workflows/approve_workflow_run.yml @@ -4,6 +4,9 @@ name: "Approve Workflow Run" on: workflow_run: + workflows: all + types: + - completed jobs: approve: From 3daeeb2ba34b8a9cde93fce2cac682378aea5e9a Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Fri, 21 May 2021 19:12:53 +0530 Subject: [PATCH 3/6] fix: more events to trigger workflow tests --- .github/workflows/approve_workflow_run.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/approve_workflow_run.yml b/.github/workflows/approve_workflow_run.yml index c74a2a0aeca2..8677d1b7cd2e 100644 --- a/.github/workflows/approve_workflow_run.yml +++ b/.github/workflows/approve_workflow_run.yml @@ -3,6 +3,7 @@ name: "Approve Workflow Run" on: + pull_request: workflow_run: workflows: all types: From 583da4584f38021f0d6ac68584ac74d1fcdeb963 Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Fri, 21 May 2021 19:14:29 +0530 Subject: [PATCH 4/6] fix: double quotes -> single quotes --- .github/workflows/approve_workflow_run.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/approve_workflow_run.yml b/.github/workflows/approve_workflow_run.yml index 8677d1b7cd2e..2a4bbdd0ff7b 100644 --- a/.github/workflows/approve_workflow_run.yml +++ b/.github/workflows/approve_workflow_run.yml @@ -12,7 +12,7 @@ on: jobs: approve: runs-on: ubuntu-latest - if: ${{ github.event.workflow_run.conclusion == "action_required" }} + if: ${{ github.event.workflow_run.conclusion == 'action_required' }} steps: - name: "Automatically approve a workflow run" run: | From 34145590dfc9e018b3b37e3eb11d7e82c51f7b8f Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Fri, 21 May 2021 19:18:33 +0530 Subject: [PATCH 5/6] fix: add workflows name to the list --- .github/workflows/approve_workflow_run.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/approve_workflow_run.yml b/.github/workflows/approve_workflow_run.yml index 2a4bbdd0ff7b..d46ffbeae752 100644 --- a/.github/workflows/approve_workflow_run.yml +++ b/.github/workflows/approve_workflow_run.yml @@ -5,7 +5,7 @@ name: "Approve Workflow Run" on: pull_request: workflow_run: - workflows: all + workflows: ['build', 'project_euler', 'pre-commit', 'directory_writer'] types: - completed From eb9609109f2726b742f9811c1ba292288e82e18f Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Fri, 21 May 2021 19:21:25 +0530 Subject: [PATCH 6/6] revert: remove added events This reverts commit 3daeeb2ba34b8a9cde93fce2cac682378aea5e9a --- .github/workflows/approve_workflow_run.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/approve_workflow_run.yml b/.github/workflows/approve_workflow_run.yml index d46ffbeae752..7c5e64452d5f 100644 --- a/.github/workflows/approve_workflow_run.yml +++ b/.github/workflows/approve_workflow_run.yml @@ -3,7 +3,6 @@ name: "Approve Workflow Run" on: - pull_request: workflow_run: workflows: ['build', 'project_euler', 'pre-commit', 'directory_writer'] types: