From faa9ae363758bdf063524089f8f7e120cb5c4d47 Mon Sep 17 00:00:00 2001 From: Sethu Date: Fri, 13 Nov 2020 13:49:16 +0530 Subject: [PATCH 1/4] Modified comments on upper.py ,made it more clean --- strings/upper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/strings/upper.py b/strings/upper.py index 411802a2a22f..e7d767d562c8 100644 --- a/strings/upper.py +++ b/strings/upper.py @@ -13,7 +13,7 @@ def upper(word: str) -> str: """ # converting to ascii value int value and checking to see if char is a lower letter - # if it is a capital letter it is getting shift by 32 which makes it a capital case + # if it is a lower letter it is getting shift by 32 which makes it a capital case # letter return "".join(chr(ord(char) - 32) if "a" <= char <= "z" else char for char in word) From b0eb2fef537ea73fed704f8d3a51ef529c9963df Mon Sep 17 00:00:00 2001 From: Sethu Date: Mon, 16 Nov 2020 23:40:15 +0530 Subject: [PATCH 2/4] Update strings/upper.py Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com> --- strings/upper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/strings/upper.py b/strings/upper.py index e7d767d562c8..57f0383be0bf 100644 --- a/strings/upper.py +++ b/strings/upper.py @@ -13,7 +13,7 @@ def upper(word: str) -> str: """ # converting to ascii value int value and checking to see if char is a lower letter - # if it is a lower letter it is getting shift by 32 which makes it a capital case + # if it is a lowercase letter it is getting shift by 32 which makes it a capital case # letter return "".join(chr(ord(char) - 32) if "a" <= char <= "z" else char for char in word) From aa65a85402a5764cee4b0e30e4fbbbd85b0e1c10 Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Wed, 18 Nov 2020 11:59:20 +0530 Subject: [PATCH 3/4] Update upper.py --- strings/upper.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/strings/upper.py b/strings/upper.py index 57f0383be0bf..3df15a3d3c2d 100644 --- a/strings/upper.py +++ b/strings/upper.py @@ -12,9 +12,9 @@ def upper(word: str) -> str: 'WH[]32' """ - # converting to ascii value int value and checking to see if char is a lower letter - # if it is a lowercase letter it is getting shift by 32 which makes it a capital case - # letter + # Converting to ascii value int value and checking to see if char is a lower letter + # if it is a lowercase letter it is getting shift by 32 which makes it an uppercase + # case letter return "".join(chr(ord(char) - 32) if "a" <= char <= "z" else char for char in word) From ad6d4748ad64dc758f815c0e66f69128d6a02734 Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Wed, 18 Nov 2020 11:59:40 +0530 Subject: [PATCH 4/4] Update upper.py --- strings/upper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/strings/upper.py b/strings/upper.py index 3df15a3d3c2d..5edd40b79808 100644 --- a/strings/upper.py +++ b/strings/upper.py @@ -13,7 +13,7 @@ def upper(word: str) -> str: """ # Converting to ascii value int value and checking to see if char is a lower letter - # if it is a lowercase letter it is getting shift by 32 which makes it an uppercase + # if it is a lowercase letter it is getting shift by 32 which makes it an uppercase # case letter return "".join(chr(ord(char) - 32) if "a" <= char <= "z" else char for char in word)