Skip to content

Pi digit extraction algorithm #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 18, 2020
Merged

Conversation

ken437
Copy link
Contributor

@ken437 ken437 commented May 18, 2020

Describe your change:

I added an algorithm that extracts the nth hexadecimal digit of pi

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ken437
Copy link
Contributor Author

ken437 commented May 18, 2020

When I tried to submit my pull request I got an error on the test saying:
Run SKIP="./.*,./other/dictionary.txt,./other/words,./project_euler/problem_22/p022_names.txt"
I don't really understand what this test is doing or why it failed, even though my code runs on my local computer.

@cclauss
Copy link
Member

cclauss commented May 18, 2020

Codespell looks for misspellings like ./maths/bbp_formula.py:4: calulate ==> calculate

ken437 and others added 4 commits May 18, 2020 03:22
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@github-actions github-actions bot force-pushed the pi_digit_extract branch from 27476e7 to 090a15b Compare May 18, 2020 07:27
@cclauss cclauss added the tests are failing Do not merge until tests pass label May 18, 2020
@cclauss cclauss merged commit 77f3888 into TheAlgorithms:master May 18, 2020
@TheSuperNoob TheSuperNoob mentioned this pull request May 22, 2020
14 tasks
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* added pi digit extraction formula

* updating DIRECTORY.md

* fixed typo in a comment

* updated bbp_formula.py

* Update maths/bbp_formula.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update maths/bbp_formula.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update bbp_formula.py

* Update and rename bbp_formula.py to bailey_borwein_plouffe.py

* updating DIRECTORY.md

* calculate

* "".join(bailey_borwein_plouffe(i) for i in range(1, 12))

* Update bailey_borwein_plouffe.py

* Update bailey_borwein_plouffe.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants