Skip to content

Commit 5ae8077

Browse files
committed
refactor: added i, j, k vectors but it does not seem to speed up the function
- Perhaps the speed gain is only on the rendering in JS
1 parent b508126 commit 5ae8077

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

src/plotly_3d_primitives/shapes.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,23 @@ def cube(
2828
y_array = [y0, y0, y1, y1, y0, y0, y1, y1]
2929
z_array = [z0, z0, z0, z0, z1, z1, z1, z1]
3030

31+
i_array = [0, 1, 4, 5, 0, 1, 0, 3, 3, 1, 1, 2]
32+
j_array = [1, 2, 5, 6, 1, 4, 3, 4, 2, 2, 5, 6]
33+
k_array = [3, 3, 7, 7, 4, 5, 4, 7, 7, 6, 6, 7]
34+
3135
mesh = go.Mesh3d(
3236
x=x_array, y=y_array, z=z_array, opacity=opacity, color=color, alphahull=0
3337
)
38+
# mesh = go.Mesh3d(
39+
# x=x_array,
40+
# y=y_array,
41+
# z=z_array,
42+
# i=i_array,
43+
# j=j_array,
44+
# k=k_array,
45+
# opacity=opacity,
46+
# color=color,
47+
# )
3448
return mesh
3549

3650

0 commit comments

Comments
 (0)