Skip to content

Commit 56c766e

Browse files
committed
Reduced code duplication, reverted changes to updateDataValue() calls, removed trailing space from deviceJoinName.
1 parent 78f05de commit 56c766e

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

devicetypes/smartthings/zwave-switch-generic.src/zwave-switch-generic.groovy

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ metadata {
3838
fingerprint mfr: "0039", prod: "4952", model: "3037", deviceJoinName: "Honeywell Z-Wave In-Wall Smart Toggle Switch"
3939
fingerprint mfr: "0039", prod: "4952", model: "3133", deviceJoinName: "Honeywell Z-Wave In-Wall Tamper Resistant Duplex Receptacle"
4040
fingerprint mfr: "001A", prod: "5244", deviceJoinName: "Eaton RF Receptacle"
41-
fingerprint mfr: "001A", prod: "534C", model: "0000", deviceJoinName: "Eaton RF Master Switch "
41+
fingerprint mfr: "001A", prod: "534C", model: "0000", deviceJoinName: "Eaton RF Master Switch"
4242
}
4343

4444
// simulator metadata
@@ -125,8 +125,8 @@ def zwaveEvent(physicalgraph.zwave.commands.manufacturerspecificv2.ManufacturerS
125125
log.debug "productId: $cmd.productId"
126126
log.debug "productTypeId: $cmd.productTypeId"
127127
def msr = String.format("%04X-%04X-%04X", cmd.manufacturerId, cmd.productTypeId, cmd.productId)
128-
device.updateDataValue("MSR", msr)
129-
device.updateDataValue("manufacturer", cmd.manufacturerName)
128+
updateDataValue("MSR", msr)
129+
updateDataValue("manufacturer", cmd.manufacturerName)
130130
createEvent([descriptionText: "$device.displayName MSR: $msr", isStateChange: false])
131131
}
132132

@@ -160,12 +160,7 @@ def off() {
160160
}
161161

162162
def poll() {
163-
def commands = []
164-
commands << zwave.switchBinaryV1.switchBinaryGet().format()
165-
if (getDataValue("MSR") == null) {
166-
commands << zwave.manufacturerSpecificV1.manufacturerSpecificGet().format()
167-
}
168-
delayBetween(commands)
163+
refresh()
169164
}
170165

171166
/**

0 commit comments

Comments
 (0)