Skip to content

Commit 7e99567

Browse files
pcuencaFahimF
andcommitted
Move code-signing to minimal xcconfig file.
Code signing is disabled for macOS. Users are instructed to update the development team when they fork or clone the repo, if they want to target iOS. Co-authored-by: Fahim Farook <fahimf@gmail.com>
1 parent b66ca88 commit 7e99567

File tree

3 files changed

+23
-2
lines changed

3 files changed

+23
-2
lines changed

Diffusion.xcodeproj/project.pbxproj

+4-2
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
EB33A51E2954E1BC00B16357 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist; path = Info.plist; sourceTree = "<group>"; };
4545
EBB5BA5229425BEE003A2A5B /* PipelineLoader.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PipelineLoader.swift; sourceTree = "<group>"; };
4646
EBB5BA5929426E06003A2A5B /* Downloader.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Downloader.swift; sourceTree = "<group>"; };
47+
EBE3FF4A295DFE2400E921AA /* common.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; name = common.xcconfig; path = config/common.xcconfig; sourceTree = "<group>"; };
4748
EBE4438729488DCA00CDA605 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
4849
EBE443892948953600CDA605 /* LICENSE */ = {isa = PBXFileReference; lastKnownFileType = text; path = LICENSE; sourceTree = "<group>"; };
4950
EBE755C5293E37DD00806B32 /* Diffusion.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Diffusion.app; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -101,6 +102,7 @@
101102
EBE755BC293E37DD00806B32 = {
102103
isa = PBXGroup;
103104
children = (
105+
EBE3FF4A295DFE2400E921AA /* common.xcconfig */,
104106
EBE4438729488DCA00CDA605 /* README.md */,
105107
EBE443892948953600CDA605 /* LICENSE */,
106108
EBE755FF293E910800806B32 /* Packages */,
@@ -478,14 +480,14 @@
478480
};
479481
EBE755EB293E37DE00806B32 /* Debug */ = {
480482
isa = XCBuildConfiguration;
483+
baseConfigurationReference = EBE3FF4A295DFE2400E921AA /* common.xcconfig */;
481484
buildSettings = {
482485
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
483486
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
484487
CODE_SIGN_ENTITLEMENTS = Diffusion/Diffusion.entitlements;
485488
CODE_SIGN_STYLE = Automatic;
486489
CURRENT_PROJECT_VERSION = 1;
487490
DEVELOPMENT_ASSET_PATHS = "\"Diffusion/Preview Content\"";
488-
DEVELOPMENT_TEAM = ZWDJQ796RU;
489491
ENABLE_HARDENED_RUNTIME = YES;
490492
ENABLE_PREVIEWS = YES;
491493
GENERATE_INFOPLIST_FILE = YES;
@@ -519,14 +521,14 @@
519521
};
520522
EBE755EC293E37DE00806B32 /* Release */ = {
521523
isa = XCBuildConfiguration;
524+
baseConfigurationReference = EBE3FF4A295DFE2400E921AA /* common.xcconfig */;
522525
buildSettings = {
523526
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
524527
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
525528
CODE_SIGN_ENTITLEMENTS = Diffusion/Diffusion.entitlements;
526529
CODE_SIGN_STYLE = Automatic;
527530
CURRENT_PROJECT_VERSION = 1;
528531
DEVELOPMENT_ASSET_PATHS = "\"Diffusion/Preview Content\"";
529-
DEVELOPMENT_TEAM = ZWDJQ796RU;
530532
ENABLE_HARDENED_RUNTIME = YES;
531533
ENABLE_PREVIEWS = YES;
532534
GENERATE_INFOPLIST_FILE = YES;

README.md

+4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ For faster inference, we use a very fast scheduler: [DPM-Solver++](https://githu
1616
* ~10s in macOS on MacBook Pro M1 Max (64 GB).
1717
* ~1 min 15s in iPhone 14 Pro.
1818

19+
## How to Build
20+
21+
If you clone or fork this repo, please update `common.xcconfig` with your development team identifier. Code signing is required to run on iOS, but it's currently disabled for macOS.
22+
1923
## Limitations
2024

2125
- The UI does not expose a way to configure the scheduler, number of inference steps, or generation seed. These are all available in the underlying code.

config/common.xcconfig

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
//
2+
// common.xcconfig
3+
// Diffusion
4+
//
5+
// Created by Pedro Cuenca on 202212.
6+
//
7+
8+
// Configuration settings file format documentation can be found at:
9+
// https://help.apple.com/xcode/#/dev745c5c974
10+
11+
// Update if you fork this repo
12+
DEVELOPMENT_TEAM = ZWDJQ796RU
13+
14+
// Disable code-signing for macOS
15+
CODE_SIGN_IDENTITY[sdk=macos*] =

0 commit comments

Comments
 (0)