Skip to content

Core: Added SSHID method to Devices #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Seluj78 merged 2 commits into from
Feb 8, 2024
Merged

Core: Added SSHID method to Devices #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebd04bf
Devices: Added method to get device's SSHID
Seluj78 Feb 7, 2024
3f179df
Devices: The sshid property will return None if device is acceptable
Seluj78 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shellhub/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Increment versions here according to SemVer
__version__ = "0.1.0"
__version__ = "0.2.0"

from .models.device import ShellHubDevice, ShellHubDeviceInfo
from .models.base import ShellHub
Expand Down
6 changes: 6 additions & 0 deletions shellhub/models/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ def refresh(self) -> None:
except requests.exceptions.HTTPError as e:
raise ShellHubApiError(e)

@property
def sshid(self) -> Optional[str]:
if self.acceptable:
return None
return f"{self.namespace}.{self.name}@{self._api._endpoint}"

def __repr__(self) -> str:
return (
f"ShellHubDevice(name={self.name}, online={self.online}, namespace={self.namespace}, status={self.status})"
Expand Down
9 changes: 9 additions & 0 deletions tests/test_devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,3 +260,12 @@ def test_accept_device(self, shellhub_device, requests_mock):
shellhub_device.accept()

assert not shellhub_device.acceptable


class TestDeviceSSHID:
def test_get_sshid(self, shellhub_device, shellhub):
assert shellhub_device.sshid == f"{shellhub_device.namespace}.{shellhub_device.name}@{shellhub._endpoint}"

def test_acceptable_device_sshid(self, shellhub_device, shellhub):
shellhub_device.acceptable = True
assert shellhub_device.sshid is None