Devices: Added support for previous versions of Python on datetime conversions

Author: Seluj78

shellhub/models/device.py

@@ -72,10 +72,25 @@ def __init__(self, api_object: shellhub.models.base.ShellHub, device_json):  # t
 
     @staticmethod
     def _safe_isoformat_to_datetime(date_string: str) -> datetime:
+        # Replace "Z" with "+00:00" to indicate UTC in a format compatible with Python 3.7-3.10.
+        if date_string.endswith("Z"):
+            date_string = date_string[:-1] + "+00:00"
         try:
+            # Direct conversion using fromisoformat
             return datetime.fromisoformat(date_string)
-        except ValueError as e:
-            raise ShellHubApiError(f"Invalid date string: {date_string} (Couldn't convert to datetime)") from e
+        except ValueError:
+            try:
+                # For Python versions that do not handle offset-aware datetimes well in fromisoformat
+                # This part is more of a catch-all to ensure even non-standard or unexpected formats
+                # might be parsed, but primarily, the first attempt should work for ISO 8601 formats.
+                # Note: strptime might not be necessary if fromisoformat works after the 'Z' to '+00:00' replacement,
+                # but it's here as an example if further customization is needed.
+                return datetime.strptime(date_string, "%Y-%m-%dT%H:%M:%S%z")
+            except ValueError as e:
+                # If the first attempt fails due to the format not being exactly ISO 8601 after 'Z' replacement,
+                # this additional attempt can catch other variations. This might not be strictly necessary,
+                # depending on your input formats.
+                raise ShellHubApiError(f"Invalid date string: {date_string} (Couldn't convert to datetime)") from e
 
     def delete(self) -> bool:
         """

tests/test_devices.py

@@ -1,4 +1,5 @@
 from datetime import datetime
+from datetime import timezone
 
 import pytest
 
@@ -106,6 +107,7 @@ def test_get_device(self, shellhub, requests_mock):
         }
         requests_mock.get(f"{MOCKED_DOMAIN_URL}/api/devices/1", json=mock_response)
         device = shellhub.get_device("1")
+        origin_time = datetime(1970, 1, 1, 0, 0, tzinfo=timezone.utc)
 
         assert device.uid == "1"
         assert device.name == "default"
@@ -120,12 +122,12 @@ def test_get_device(self, shellhub, requests_mock):
             == "-----BEGIN RSA PUBLIC KEY-----\nxxx\nxxx\nxxx\nxxx\nxxx\nxxx\n-----END RSA PUBLIC KEY-----\n"
         )
         assert device.tenant_id == "1"
-        assert device.last_seen == datetime.fromisoformat("1970-01-01T00:00:00Z")
+        assert device.last_seen == origin_time
         assert device.online
         assert device.namespace == "dev"
         assert device.status == "accepted"
-        assert device.status_updated_at == datetime.fromisoformat("1970-01-01T00:00:00Z")
-        assert device.created_at == datetime.fromisoformat("1970-01-01T00:00:00Z")
+        assert device.status_updated_at == origin_time
+        assert device.created_at == origin_time
         assert device.remote_addr == "0.0.0.0"
         assert device.tags == []
         assert not device.acceptable