Add basic support for no_proxy environment variable (getsentry#838)

Author: xavfernandez

sentry_sdk/transport.py

@@ -276,6 +276,17 @@ def _get_pool_options(self, ca_certs):
             "ca_certs": ca_certs or certifi.where(),
         }
 
+    def _in_no_proxy(self, parsed_dsn):
+        # type: (Dsn) -> bool
+        no_proxy = getproxies().get("no")
+        if not no_proxy:
+            return False
+        for host in no_proxy.split(","):
+            host = host.strip()
+            if parsed_dsn.host.endswith(host) or parsed_dsn.netloc.endswith(host):
+                return True
+        return False
+
     def _make_pool(
         self,
         parsed_dsn,  # type: Dsn
@@ -285,14 +296,15 @@ def _make_pool(
     ):
         # type: (...) -> Union[PoolManager, ProxyManager]
         proxy = None
+        no_proxy = self._in_no_proxy(parsed_dsn)
 
         # try HTTPS first
         if parsed_dsn.scheme == "https" and (https_proxy != ""):
-            proxy = https_proxy or getproxies().get("https")
+            proxy = https_proxy or (not no_proxy and getproxies().get("https"))
 
         # maybe fallback to HTTP proxy
         if not proxy and (http_proxy != ""):
-            proxy = http_proxy or getproxies().get("http")
+            proxy = http_proxy or (not no_proxy and getproxies().get("http"))
 
         opts = self._get_pool_options(ca_certs)
 

tests/test_client.py

@@ -187,13 +187,52 @@ def test_transport_option(monkeypatch):
             "arg_https_proxy": None,
             "expected_proxy_scheme": "http",
         },
+        # NO_PROXY testcases
+        {
+            "dsn": "http://foo@sentry.io/123",
+            "env_http_proxy": "http://localhost/123",
+            "env_https_proxy": None,
+            "env_no_proxy": "sentry.io,example.com",
+            "arg_http_proxy": None,
+            "arg_https_proxy": None,
+            "expected_proxy_scheme": None,
+        },
+        {
+            "dsn": "https://foo@sentry.io/123",
+            "env_http_proxy": None,
+            "env_https_proxy": "https://localhost/123",
+            "env_no_proxy": "example.com,sentry.io",
+            "arg_http_proxy": None,
+            "arg_https_proxy": None,
+            "expected_proxy_scheme": None,
+        },
+        {
+            "dsn": "http://foo@sentry.io/123",
+            "env_http_proxy": None,
+            "env_https_proxy": None,
+            "env_no_proxy": "sentry.io,example.com",
+            "arg_http_proxy": "http://localhost/123",
+            "arg_https_proxy": None,
+            "expected_proxy_scheme": "http",
+        },
+        {
+            "dsn": "https://foo@sentry.io/123",
+            "env_http_proxy": None,
+            "env_https_proxy": None,
+            "env_no_proxy": "sentry.io,example.com",
+            "arg_http_proxy": None,
+            "arg_https_proxy": "https://localhost/123",
+            "expected_proxy_scheme": "https",
+        },
     ],
 )
 def test_proxy(monkeypatch, testcase):
     if testcase["env_http_proxy"] is not None:
         monkeypatch.setenv("HTTP_PROXY", testcase["env_http_proxy"])
     if testcase["env_https_proxy"] is not None:
         monkeypatch.setenv("HTTPS_PROXY", testcase["env_https_proxy"])
+    if testcase.get("env_no_proxy") is not None:
+        monkeypatch.setenv("NO_PROXY", testcase["env_no_proxy"])
     kwargs = {}
     if testcase["arg_http_proxy"] is not None:
         kwargs["http_proxy"] = testcase["arg_http_proxy"]