PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

//yield return new TestCaseData(new LocalValue.Boolean(true), new RemoteValue.Boolean(true), "typeof arg === true")
//{
//    TestName = nameof(CanCallFunctionAndRoundtrip_Five) + "(true)",
//};
//yield return new TestCaseData(new LocalValue.Boolean(false), new RemoteValue.Boolean(false), "typeof arg === false")
//{
//    TestName = nameof(CanCallFunctionAndRoundtrip_Five) + "(false)",
//};

PR Code Suggestions ✨

Explore these optional code suggestions:

-        //yield return new TestCaseData(new LocalValue.Boolean(true), new RemoteValue.Boolean(true), "typeof arg === true")
-        //{
-        //    TestName = nameof(CanCallFunctionAndRoundtrip_Five) + "(true)",
-        //};
-        //yield return new TestCaseData(new LocalValue.Boolean(false), new RemoteValue.Boolean(false), "typeof arg === false")
-        //{
-        //    TestName = nameof(CanCallFunctionAndRoundtrip_Five) + "(false)",
-        //};

-//yield return new TestCaseData(new LocalValue.Boolean(true), new RemoteValue.Boolean(true), "typeof arg === true")
+//yield return new TestCaseData(new LocalValue.Boolean(true), new RemoteValue.Boolean(true), "arg === true")
 //{
 //    TestName = nameof(CanCallFunctionAndRoundtrip_Five) + "(true)",
 //};
-//yield return new TestCaseData(new LocalValue.Boolean(false), new RemoteValue.Boolean(false), "typeof arg === false")
+//yield return new TestCaseData(new LocalValue.Boolean(false), new RemoteValue.Boolean(false), "arg === false")
 //{
 //    TestName = nameof(CanCallFunctionAndRoundtrip_Five) + "(false)",
 //};

We learned:

• double.NegativeZero is a .NET type for -0
• Special converters should be applied for special cases only

I propose to gather how vendors serialize special numbers in JSON, then it will be easier for us to handle.

For de-serializing a -0:
await context.Script.CallFunctionAsync("() => { return -0; }", false);

• Firefox: {"type":"number","value":"-0"}
• Chrome: {"type":"number","value":"-0"}

For serializing a -0:

var minus0 = new LocalValue.Number(double.NegativeZero);

await context.Script.CallFunctionAsync($$"""
    (arg) => {
        if (arg !== 0 || arg.toLocaleString()[0] !== '-') {
        throw new Error("Assert failed: " + arg.toLocaleString());
        }
    }
    """, false, new() { Arguments = [minus0] });

When arguments are serialized as "arguments":[{"type":"number","value":-0}]

• On Firefox: Error: Assert failed: 0 (in other words, it thinks the value is regular 0)
• On Chrome: Error: Assert failed: 0 (same as above)

When arguments are serialized as "arguments":[{"type":"number","value":"-0"}]

• On Firefox: No exception is thrown ("is negative zero" check passed)
• On Chrome: No exception is thrown

Conclusion

Across the board, for serializing and deserializing, on all browsers, negative zero is expected to be a string "-0"

When arguments are serialized as "arguments":[{"type":"number","value":-0}] On Firefox: Error: Assert failed: 0 (in other words, it thinks the value is regular 0)

On my Firefox your test passes when we {"type":"number","value":-0}

OK, so in Firefox everything works good without any custom double converters. Chromium cannot handle -0 and everything works good.

I posted w3c/webdriver-bidi#887 issue in BiDi spec. I propose to not introduce custom converter at this time, and move forward with ignored unit tests (for chromium only).

PS: I was wrong, spec requires -0 to be string:

[Type](https://tc39.es/ecma262/#sec-ecmascript-data-types-and-values)(value) is Number
Switch on the value of value:

NaN
Let serialized be "NaN"
-0
Let serialized be "-0"

Formatting build failure unrelated:

--- a/py/test/selenium/webdriver/common/selenium_manager_tests.py
+++ b/py/test/selenium/webdriver/common/selenium_manager_tests.py

Test failures not related:

//py:common-chrome-bidi-test/selenium/webdriver/common/bidi_tests.py
//py:common-edge-bidi-test/selenium/webdriver/common/bidi_tests.py
//rb/spec/integration/selenium/webdriver:action_builder-chrome-remote
//rb/spec/integration/selenium/webdriver:driver-chrome
//rb/spec/integration/selenium/webdriver:driver-chrome-remote
//rb/spec/integration/selenium/webdriver:driver-firefox-beta
//rb/spec/integration/selenium/webdriver:manager-chrome
//rb/spec/integration/selenium/webdriver:select-chrome
//rb/spec/integration/selenium/webdriver:select-chrome-remote