Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SciML/RecursiveArrayTools.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.39.0
Choose a base ref
...
head repository: SciML/RecursiveArrayTools.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Oct 24, 2025

  1. Fix recursivefill! failure with immutable StaticArrays (issue #461) 

    This commit fixes a bug where `recursivefill!` would fail when called on
a `VectorOfArray` containing immutable `StaticArray` types like `SVector`.

## Problem
The `Base.fill!` method for `AbstractVectorOfArray` attempted to call
`fill!` on each element array, which fails for immutable arrays that don't
support in-place modification via `setindex!`.

## Solution
Modified `Base.fill!` to check if each element is mutable before attempting
to fill it. For immutable arrays, we now create a new filled array using
`StaticArraysCore.similar_type` and assign it, following the same pattern
used in the existing `copyto!` implementation.

## Changes
- Updated `Base.fill!` in `src/vector_of_array.jl` to handle both mutable
  and immutable arrays correctly
- Added comprehensive tests in `test/utils_test.jl` to cover:
  - `VectorOfArray` with only immutable `SVector`s
  - `VectorOfArray` with mixed immutable and mutable `StaticArray`s
  - Both `recursivefill!` and `fill!` methods

All existing tests continue to pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @ChrisRackauckas @claude
    ChrisRackauckas and claude committed Oct 24, 2025
    Configuration menu
    Copy the full SHA
    059ae4d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #493 from ChrisRackauckas-Claude/fix-recursivefill… 

    …-immutable-staticarrays

Fix recursivefill! failure with immutable StaticArrays
    @ChrisRackauckas
    ChrisRackauckas authored Oct 24, 2025
    Configuration menu
    Copy the full SHA
    9193003 View commit details
    Browse the repository at this point in the history

  3. Fix view of VectorOfArray with heterogeneous array sizes 

    Fixes #453

The issue was that `view(f, :, i)` for a VectorOfArray with
heterogeneous inner array sizes returned incorrect results. The
problem was that `to_indices` uses `axes`, which is based on the
first element's size, causing views of columns with different sizes
to have incorrect dimensions.

Solution: Added special handling for `view(A, :, i)` where `i` is
an Int, to use the actual size of the specific column being viewed
rather than relying on `to_indices`.

Changes:
- Modified Base.view for AbstractVectorOfArray to handle heterogeneous
  arrays by computing the correct indices based on the actual column size
- Added comprehensive tests for views of heterogeneous arrays including:
  * Testing correct lengths of views
  * Testing that views match regular indexing
  * Testing that views can be modified

All existing tests pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @ChrisRackauckas @claude
    ChrisRackauckas and claude committed Oct 24, 2025
    Configuration menu
    Copy the full SHA
    63c3de8 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #494 from ChrisRackauckas-Claude/fix-heterogeneous… 

    …-view-issue-453

Fix view of VectorOfArray with heterogeneous array sizes
    @ChrisRackauckas
    ChrisRackauckas authored Oct 24, 2025
    Configuration menu
    Copy the full SHA
    3710526 View commit details
    Browse the repository at this point in the history
Loading