Merge pull request #10 from rdeits/fix-similar

more type-stable versions of `similar()` and some tests

Author: ChrisRackauckas

src/array_partition.jl

@@ -9,9 +9,10 @@ function ArrayPartition{T,T2<:Tuple}(x::T2,::Type{Val{T}}=Val{false})
     return ArrayPartition{T2}((x...))
   end
 end
-Base.similar(A::ArrayPartition) = ArrayPartition((similar(x) for x in A.x)...)
-Base.similar(A::ArrayPartition,dims::Tuple) = ArrayPartition((similar(x,dim) for (x,dim) in zip(A.x,dims))...)
-Base.similar(A::ArrayPartition,T,dims::Tuple) = ArrayPartition((similar(x,T,dim) for (x,dim) in zip(A.x,dims))...)
+Base.similar(A::ArrayPartition) = ArrayPartition((similar.(A.x))...)
+Base.similar(A::ArrayPartition, dims::Tuple) = ArrayPartition(similar.(A.x, dims)...)
+Base.similar(A::ArrayPartition, T, dims::Tuple) = ArrayPartition(similar.(A.x, T, dims)...)
+
 Base.copy(A::ArrayPartition) = Base.similar(A)
 Base.zeros(A::ArrayPartition) = ArrayPartition((zeros(x) for x in A.x)...)
 

test/partitions_test.jl

@@ -23,3 +23,15 @@ p .= (*).(p,5)
 p .= (*).(p,a)
 p .= (*).(p,p2)
 K = (*).(p,p2)
+
+x = ArrayPartition([1, 2], [3.0, 4.0])
+@inferred(similar(x))
+@inferred(similar(x, (2, 2)))
+@test_broken @inferred(similar(x, Int, (2, 2)))
+@test_broken @inferred(similar(x, (Int, Float64), (2, 2)))
+
+_scalar_op(y) = y + 1
+# Can't do `@inferred(_scalar_op.(x))` so we wrap that in a function:
+_broadcast_wrapper(y) = _scalar_op.(y)
+# Issue #8
+@inferred(_broadcast_wrapper(x))