Duplicate Global Parameters

[bradcarman]

When using GlobalScope() for child components, the parent component then contains duplicates of the global parameter. See https://discourse.julialang.org/t/how-to-create-global-parameters-in-modelingtoolkit-jl/60065/4?u=brad_carman for an example reproduction of the bug.

[hersle]

This is no longer an issue.

using ModelingToolkit
using ModelingToolkit: t_nounits as t, D_nounits as D

@variables p(t)
@parameters rho
rho = GlobalScope(rho)

fluid(;name) = ODESystem(Equation[], t, [p], [rho]; defaults=[rho=>1000, p=>0], name)

@named A = fluid()
@named B = fluid()

eqs = [
    D(B.p) ~ A.p
    0 ~ (A.p) - (A.rho)
]

@named comp = ODESystem(eqs, t, [], []; systems=[A, B])

gives only one rho in

Model comp with 2 equations
Unknowns (2):
  A₊p(t) [defaults to 0]
  B₊p(t) [defaults to 0]
Parameters (1):
  rho [defaults to 1000]