Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for internal parameters #3460

Open
TorkelE opened this issue Mar 15, 2025 · 4 comments
Open

Add metadata for internal parameters #3460

TorkelE opened this issue Mar 15, 2025 · 4 comments

Comments

@TorkelE
Copy link
Member

TorkelE commented Mar 15, 2025

So right now we have parameters that the user is aware of, and then stuff that MTK adds on its own accord. Basically the difference between what get_ps and `parameters return.

Would it make sense to have a metadata entry for "internal parameters" (with a value set to true). That was one could easily check if a parameter is relevant to the user or not. That way it might be easier to handle functions like parameters. I.e. right now if MTK adds a new internal parameter, unless I am told an updated Catalyst code internally we will get a problem (and wherever we take this into account). However, this way, when a new type of internal parameter is introduced the metadata could just be checked as true and, at least some stuff in SciML, might automatically take this into account.

@ChrisRackauckas
Copy link
Member

The idea of an "internal" parameter isn't well defined? D(x) ~ 0 is that internal?

@TorkelE
Copy link
Member Author

TorkelE commented Mar 17, 2025

sorry, what is the parameter in that? In this case internal parameters to me are parameters stored in the get_ps field but which is not returned by parameters (but are returned by get_ps).

@ChrisRackauckas
Copy link
Member

It's a state that a user defines that can become a parameter because it doesn't need to be solved by the ODE solver.

@TorkelE
Copy link
Member Author

TorkelE commented Mar 17, 2025

Agreed, that makes sense. Then I guess it depends on what MTK considers it in in parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants