Skip to content

Commit ef70a28

Browse files
authored
Go back to using explicit node verisons in CI (microsoft#51965)
Fixes microsoft#51943
1 parent 70ee780 commit ef70a28

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

.github/workflows/ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
# Test the latest version of Node.js plus the last two LTS versions.
2019
node-version:
21-
- "*"
22-
- lts/*
23-
- lts/-1
20+
- "19"
21+
- "18"
22+
- "16"
23+
- "14"
2424
bundle:
2525
- "true"
2626
include:

src/compiler/watch.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,12 @@ function getPlainDiagnosticFollowingNewLines(diagnostic: Diagnostic, newLine: st
172172
export function getLocaleTimeString(system: System) {
173173
return !system.now ?
174174
new Date().toLocaleTimeString() :
175-
system.now().toLocaleTimeString("en-US", { timeZone: "UTC" });
175+
// On some systems / builds of Node, there's a non-breaking space between the time and AM/PM.
176+
// This branch is solely for testing, so just switch it to a normal space for baseline stability.
177+
// See:
178+
// - https://github.com/nodejs/node/issues/45171
179+
// - https://github.com/nodejs/node/issues/45753
180+
system.now().toLocaleTimeString("en-US", { timeZone: "UTC" }).replace("\u202f", " ");
176181
}
177182

178183
/**

0 commit comments

Comments
 (0)