Skip to content

Commit e58ebfe

Browse files
committed
Changed, that the default limit_value for pagination is based on default_per_page
Closes elastic#68
1 parent fa37bc6 commit e58ebfe

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: elasticsearch-model/lib/elasticsearch/model/response/pagination.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def limit_value
5050
when search.definition[:size]
5151
search.definition[:size]
5252
else
53-
0
53+
search.klass.default_per_page
5454
end
5555
end
5656

Diff for: elasticsearch-model/test/unit/response_pagination_test.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def self.document_type; 'bar'; end
1313
'hits' => { 'total' => 100, 'hits' => (1..100).to_a.map { |i| { _id: i } } } }
1414

1515
setup do
16-
@search = Elasticsearch::Model::Searching::SearchRequest.new ModelClass, '*'
16+
@search = Elasticsearch::Model::Searching::SearchRequest.new ModelClass, '*'
1717
@response = Elasticsearch::Model::Response::Response.new ModelClass, @search, RESPONSE
1818
@response.klass.stubs(:client).returns mock('client')
1919
end
@@ -62,7 +62,7 @@ def self.document_type; 'bar'; end
6262

6363
context "limit/offset readers" do
6464
should "return the default" do
65-
assert_equal 0, @response.limit_value
65+
assert_equal Kaminari.config.default_per_page, @response.limit_value
6666
assert_equal 0, @response.offset_value
6767
end
6868

0 commit comments

Comments
 (0)