[STORE] Added the method_added hook to allow defining gateway methods directly in the class

Instead of calling the `gateway` method with a block, to redefine the serialize/deserialize methods:

    class NoteRepository
      gateway do
        def serialize(document)
          Hash[document.to_hash.map() { |k,v|  v.upcase! if k == :title; [k,v] }]
        end
        def deserialize(document)
          MyNote.new ActiveSupport::HashWithIndifferentAccess.new(document['_source']).deep_symbolize_keys
        end
      end
    end

Define them directly in the class, and they will be intercepted by the hook, and (re)defined directly on the gateway:

    class NoteRepository
      def serialize(document)
        Hash[document.to_hash.map() { |k,v|  v.upcase! if k == :title; [k,v] }]
      end
      def deserialize(document)
        MyNote.new ActiveSupport::HashWithIndifferentAccess.new(document['_source']).deep_symbolize_keys
      end
    end

See: http://www.ruby-doc.org/core-2.1.1/Module.html#method-i-method_added

(COMITTED WITH FINGERS CROSSED :)

Author: karmi

Diff for: elasticsearch-persistence/lib/elasticsearch/persistence/repository.rb

@@ -35,6 +35,12 @@ def self.included(base)
 
           include GatewayDelegation
         end
+
+        def base.method_added(name)
+          if :gateway != name && respond_to?(:gateway) && (gateway.public_methods - Object.public_methods).include?(name)
+            gateway.define_singleton_method(name, self.new.method(name).to_proc)
+          end
+        end
       end
 
       def new(options={}, &block)

Diff for: elasticsearch-persistence/test/unit/repository_module_test.rb

@@ -86,8 +86,8 @@ class DummyRepository
         assert_equal 'snowball', repository.mappings.to_hash[:my_dummy_model][:properties][:title][:analyzer]
       end
 
-      should "allow to define gateway methods in the class definition" do
-        class DummyRepository
+      should "allow to define gateway methods in the class definition via block passed to the gateway method" do
+        class DummyRepositoryWithGatewaySerialize
           include Elasticsearch::Persistence::Repository
 
           gateway do
@@ -97,7 +97,7 @@ def serialize(document)
           end
         end
 
-        repository = DummyRepository.new
+        repository = DummyRepositoryWithGatewaySerialize.new
         repository.client.transport.logger = Logger.new(STDERR)
 
         client = mock
@@ -113,6 +113,30 @@ def serialize(document)
       end
     end
 
+    should "allow to define gateway methods in the class definition via regular method definition" do
+      class DummyRepositoryWithDirectSerialize
+        include Elasticsearch::Persistence::Repository
+
+        def serialize(document)
+          'FAKE IN CLASS!'
+        end
+      end
+
+      repository = DummyRepositoryWithDirectSerialize.new
+      repository.client.transport.logger = Logger.new(STDERR)
+
+      client = mock
+      client.expects(:index).with do |arguments|
+        assert_equal('xxx',   arguments[:id])
+        assert_equal('FAKE IN CLASS!', arguments[:body])
+      end
+      repository.gateway.expects(:client).returns(client)
+
+      repository.gateway.expects(:__get_id_from_document).returns('xxx')
+
+      repository.save( id: '123', foo: 'bar' )
+    end
+
     should "configure the index name in the shortcut initializer" do
       assert_equal 'repository', Elasticsearch::Persistence::Repository.new.index_name
     end