Skip to content

Commit edb01bc

Browse files
committed
Log certificate's serial number as stringified decimal number
Using a JSON string fixes a common issue with JSON parsers that deserialize all numbers to a 64-bit IEEE-754 floats. (Certificate serial numbers are usually 128 bit values.) This change is consistent with existing log entries for revocation requests. See also: smallstep#630, smallstep#631
1 parent b9743b3 commit edb01bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

api/api.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ func logOtt(w http.ResponseWriter, token string) {
400400
func LogCertificate(w http.ResponseWriter, cert *x509.Certificate) {
401401
if rl, ok := w.(logging.ResponseLogger); ok {
402402
m := map[string]interface{}{
403-
"serial": cert.SerialNumber,
403+
"serial": cert.SerialNumber.String(),
404404
"subject": cert.Subject.CommonName,
405405
"issuer": cert.Issuer.CommonName,
406406
"valid-from": cert.NotBefore.Format(time.RFC3339),

0 commit comments

Comments
 (0)