fix(istio): github service fix

Author: rolandszoke

istio_examples/Services/api/src/server.js

@@ -13,12 +13,16 @@ app.get('/api', (req, res) => res.json({
   version: VERSION
 }))
 app.get('/api/git', async (req, res) => {
-  console.log('sending request: http://github.default.svc.cluster.local:5000/api/v1')
-  const response = await request({
-    method: 'GET',
-    uri: `http://github.default.svc.cluster.local:5000/api/v1`
-  })
-  res.json(response)
+  try {
+    const response = await request({
+      method: 'GET',
+      uri: `http://github.default.svc.cluster.local:5000/api/v1`
+    })
+    return res.json(JSON.parse(response))
+  } catch (err) {
+    console.log(err)
+    return res.sendStatus(500)
+  }
 })
 
 app.listen(PORT, () => console.log(`Example app listening on port ${PORT}!`))

istio_examples/Services/deploy.sh

@@ -17,3 +17,6 @@ done
 
 kubectl delete ingress gateway
 kubectl apply -f <(istioctl kube-inject -f $DIR/ingress.yml)
+
+kubectl delete egressrule github-egress
+kubectl apply -f <(istioctl kube-inject -f $DIR/egress.yml)

istio_examples/Services/egress.yml

@@ -0,0 +1,14 @@
+apiVersion: config.istio.io/v1alpha2
+kind: EgressRule
+metadata:
+  name: github-egress
+  label:
+    app: github
+spec:
+  destination:
+    service: "*.github.com"
+  ports:
+    - port: 443
+      protocol: https
+    - port: 80
+      protocol: http

istio_examples/Services/github/src/package.json

@@ -12,6 +12,7 @@
   "dependencies": {
     "cors": "^2.8.4",
     "express": "4.16.2",
+    "lodash": "^4.17.4",
     "request": "2.83.0",
     "request-promise-native": "1.0.5"
   }

istio_examples/Services/github/src/server.js

@@ -2,26 +2,25 @@ const request = require('request-promise-native')
 const express = require('express')
 const app = express()
 const cors = require('cors')
+const _ = require('lodash')
 app.use(cors())
 
 const PORT = process.env.PORT
 
 app.get('/healthz', (req, res) => res.sendStatus(200))
 app.get('/api/v1', async (req, res) => {
-  console.log(`request recieved!`)
   try {
     const {items} = await request({
       method: 'GET',
-      uri: 'https://api.github.com/search/repositories',
+      uri: 'http://api.github.com:443/search/repositories',
       headers: {
         Accept: 'application/vnd.github.v3+json',
         'User-Agent': 'RisingStack'
       },
       qs: { q: 'risingstack-bootcamp' },
       json: true
     })
-    console.log(items)
-    return res.send(items[0])
+    return res.json(_.pickBy(items[0], _.identity))
   } catch (err) {
     console.log(err)
     return res.sendStatus(500)

istio_examples/Services/ui/src/src/App.js

@@ -37,7 +37,7 @@ class App extends Component {
         <button onClick={this.callAPIgit}>Call API git</button>
         <p></p>
         {!this.state.error 
-          ? _.map(data, (value, key) => {return(<div key={key}>{key}: <b>{value}</b></div>)})
+          ? _.map(data, (value, key) => {return(<div key={key}>{key}: <b>{value.toString()}</b></div>)})
           : <div className="error">Error: <b>{this.state.data}</b></div>
         }
       </div>