Skip to content

Commit 3561d43

Browse files
committed
reafactor(istio): routerule refactor and cleanup
1 parent a284d07 commit 3561d43

File tree

10 files changed

+4
-53
lines changed

10 files changed

+4
-53
lines changed

istio_examples/RouteRule/api/deployment-local.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ spec:
2121
env:
2222
- name: VERSION
2323
value: "v1"
24-
- name: POD_NAMESPACE
25-
valueFrom:
26-
fieldRef:
27-
fieldPath: metadata.namespace
2824
---
2925
apiVersion: extensions/v1beta1
3026
kind: Deployment
@@ -49,7 +45,3 @@ spec:
4945
env:
5046
- name: VERSION
5147
value: "v2"
52-
- name: POD_NAMESPACE
53-
valueFrom:
54-
fieldRef:
55-
fieldPath: metadata.namespace

istio_examples/RouteRule/api/deployment.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ spec:
2222
env:
2323
- name: VERSION
2424
value: "v1"
25-
- name: POD_NAMESPACE
26-
valueFrom:
27-
fieldRef:
28-
fieldPath: metadata.namespace
2925
---
3026
apiVersion: extensions/v1beta1
3127
kind: Deployment
@@ -51,7 +47,3 @@ spec:
5147
env:
5248
- name: VERSION
5349
value: "v2"
54-
- name: POD_NAMESPACE
55-
valueFrom:
56-
fieldRef:
57-
fieldPath: metadata.namespace

istio_examples/RouteRule/api/service.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ metadata:
77
spec:
88
selector:
99
app: api
10-
type: LoadBalancer
10+
type: ClusterIP
1111
ports:
1212
- protocol: TCP
1313
port: 5000

istio_examples/RouteRule/api/src/server.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,3 @@ app.get('/api', (req, res) => res.json({
1313
}))
1414

1515
app.listen(PORT, () => console.log(`Example app listening on port ${PORT}!`))
16-
17-
// TODO: remove this part
18-
setInterval(() => {
19-
require('request')(`http://api.default.svc.cluster.local/api`, (error, response, body) => {
20-
console.log(error || body)
21-
})
22-
}, 1000)

istio_examples/RouteRule/deploy-local.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# RUN these command once before deploy
44
# minikube start
55
# eval $(minikube docker-env)
6-
# echo "$(minikube ip) risingstack.training.kubernetes.com" | sudo tee -a /etc/hosts
6+
# echo "$(minikube ip) risingstack.training.example.com" | sudo tee -a /etc/hosts
77

88
DIR=$(pwd)
99

istio_examples/RouteRule/deploy.sh

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,6 @@ done
1818
kubectl delete ingress gateway
1919
kubectl apply -f <(istioctl kube-inject -f $DIR/ingress.yml)
2020

21-
# INGRESS_IP=""
22-
# while [ -z $INGRESS_IP ]; do
23-
# sleep 10
24-
# INGRESS_IP=$(kubectl get ingress gateway -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
25-
# done
26-
27-
# API_URL="http://$INGRESS_IP"
28-
# kubectl patch deployment ui --patch '{"spec": {"template": {"spec": {"containers": [{"name": "ui", "env":[{"name": "REACT_APP_API_URL", "value": "'$API_URL'"}]}]}}}}'
29-
3021
kubectl delete routerule -l app=api
3122
kubectl apply -f <(istioctl kube-inject -f $DIR/api/routerule.yml)
3223
kubectl apply -f <(istioctl kube-inject -f $DIR/api/routerule2.yml)

istio_examples/RouteRule/ingress-local.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
ingress.kubernetes.io/rewrite-target: /
77
spec:
88
rules:
9-
- host: risingstack.training.kubernetes.com
9+
- host: risingstack.training.example.com
1010
http:
1111
paths:
1212
- path: /api

istio_examples/RouteRule/ui/deployment-local.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,3 @@ spec:
1616
image: k8s/ui:v1
1717
ports:
1818
- containerPort: 80
19-
env:
20-
- name: REACT_APP_API_URL
21-
value: 'http://risingstack.training.kubernetes.com'

istio_examples/RouteRule/ui/service.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ metadata:
77
spec:
88
selector:
99
app: ui
10-
type: LoadBalancer
10+
type: ClusterIP
1111
ports:
1212
- protocol: TCP
1313
port: 80

istio_examples/RouteRule/ui/src/Dockerfile

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,3 @@
1-
# FROM node:8.9.4-alpine
2-
3-
# ENV PORT 3000
4-
5-
# COPY package.json package.json
6-
# RUN npm install
7-
8-
# COPY . .
9-
10-
# EXPOSE $PORT
11-
# CMD ["npm", "start"]
12-
13-
#########################
14-
151
FROM node:8.9.4-alpine as build-deps
162

173
WORKDIR /usr/src/app

0 commit comments

Comments
 (0)