Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Missing NonNull annotation on Maybe<T> #7435

Closed
KarboniteKream opened this issue Jun 4, 2022 · 2 comments · Fixed by #7436
Closed

3.x: Missing NonNull annotation on Maybe<T> #7435

KarboniteKream opened this issue Jun 4, 2022 · 2 comments · Fixed by #7436
Labels
3.x PR welcome

Comments

@KarboniteKream
Copy link
Contributor

In #6840, the @NonNull annotation was added to various class generic types, including MaybeSource.
However, the annotation was omitted from Maybe itself. Was this intentional or was it just overlooked?

Apologies if this has been asked before, but I couldn't find any related issues/PRs.
@akarnokd
Copy link
Member

akarnokd commented Jun 4, 2022

Looks like a simple oversight. PR welcome.

@KarboniteKream
Copy link
Contributor Author

Thanks for the clarification, let me submit it

@KarboniteKream KarboniteKream mentioned this issue Jun 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x PR welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3.x: Add missing @NonNull annotation to Maybe type argument KarboniteKream/RxJava
2 participants
@akarnokd @KarboniteKream