Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Revise AtomicThrowable.addThrowable usage #6611

Closed
akarnokd opened this issue Aug 5, 2019 · 2 comments · Fixed by #6639
Closed

3.x: Revise AtomicThrowable.addThrowable usage #6611

akarnokd opened this issue Aug 5, 2019 · 2 comments · Fixed by #6639
Milestone

Comments

@akarnokd
Copy link
Member

akarnokd commented Aug 5, 2019

Currently, many (if not all?) usage of addThrowable is as follows:

if (errors.addThrowable(ex)) {
   // do something with the error case
} else {
    RxJavaPlugins.onError(ex);
}

The plugin error call could be inlined into the method call and renamed to tryAddThrowable to ensure all usage places are updated correctly.

@RomanWuattier
Copy link
Contributor

Hey, do you need help doing this?

@akarnokd
Copy link
Member Author

akarnokd commented Aug 6, 2019

Each usage location has to be reevaluated and there are thousands of those. It would be easier if I do them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants