Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove onExceptionResumeNext? #6554

Closed
akarnokd opened this issue Jul 3, 2019 · 2 comments · Fixed by #6564
Closed

Remove onExceptionResumeNext? #6554

akarnokd opened this issue Jul 3, 2019 · 2 comments · Fixed by #6564
Labels
3.x Discussion
Milestone
3.0

Comments

@akarnokd
Copy link
Member

akarnokd commented Jul 3, 2019

JavaDocs

I don't remember ever needing, asked for or recommended this operator? The difference from onErrorResumeNext is that anything that's not extending Exception can pass through. I believe it was added to support some internal Netflix operation. It can be emulated via onErrorResumeNext:

source.onErrorResumeNext(
    error -> error instanceof Exception 
        ? fallback : Obserable.error(error))
@akarnokd akarnokd added this to the 3.0 milestone Jul 3, 2019
@vanniktech
Copy link
Collaborator

Never used onExceptionResumeNext.

@suribada
Copy link

suribada commented Jul 4, 2019

It was rather more confusing.

@akarnokd akarnokd mentioned this issue Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x Discussion
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

3.x: remove buffer/window with supplier & onExceptionResumeNext akarnokd/RxJava
3 participants
@akarnokd @suribada @vanniktech