Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Nebula plugin for 2.x #4032

Closed
3 tasks
akarnokd opened this issue Jun 19, 2016 · 3 comments
Closed
3 tasks

Remove dependency on Nebula plugin for 2.x #4032

akarnokd opened this issue Jun 19, 2016 · 3 comments
Labels
Milestone

Comments

@akarnokd
Copy link
Member

(Previously came up in #3170)

In the past, the Nebula plugin was source of trouble and RxAndroid got rid of it some time ago. This suggests and issue tracks the removal of Nebula and the replacement of its relevant features:

  • Remove from build.gradle
  • Make sure creating a release through Github still triggers an upload to maven from Travis CI
  • Make sure patch version numbers are automatically incremented and inferred
@ZacSweers
Copy link
Contributor

What were the benefits of it? From what I remember the most common usage was its provided plugin but that exists natively through gradle now as compileOnly.

The maven releases via travis should totally be doable.

Automating patch versions should be easy too, could easily make that a tiny gradle task

@akarnokd
Copy link
Member Author

Great! Anybody who wants to tackle this, a PR are welcome. Please notify us if someone starts working on this so won't get PR conflicts on build.gradle updates (like PMD).

@akarnokd
Copy link
Member Author

Closing. I don't have the skill and nobody else picked this up. The current nebula setup works anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants