correct initialization code (python#3376)

benjaminp · web-flow · commit b0a9a5a6a478 · 2017-09-05T20:19:12.000-07:00
Explicitly initialize struct members rather than relying on compiler extensions.
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -77,7 +77,7 @@ extern void _PyGILState_Init(PyInterpreterState *, PyThreadState *);
 extern void _PyGILState_Fini(void);
 #endif /* WITH_THREAD */
 
-_PyRuntimeState _PyRuntime = {};
+_PyRuntimeState _PyRuntime = {0, 0};
 
 void
 _PyRuntime_Initialize(void)
diff --git a/Python/pystate.c b/Python/pystate.c
@@ -37,8 +37,7 @@ extern "C" {
 void
 _PyRuntimeState_Init(_PyRuntimeState *runtime)
 {
-    _PyRuntimeState initial = {};
-    *runtime = initial;
+    memset(runtime, 0, sizeof(*runtime));
 
     _PyObject_Initialize(&runtime->obj);
     _PyMem_Initialize(&runtime->mem);

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,7 @@ extern "C" {`
`37`	`37`	`void`
`38`	`38`	`_PyRuntimeState_Init(_PyRuntimeState *runtime)`
`39`	`39`	`{`
`40`		`- _PyRuntimeState initial = {};`
`41`		`- *runtime = initial;`
	`40`	`+ memset(runtime, 0, sizeof(*runtime));`
`42`	`41`
`43`	`42`	`_PyObject_Initialize(&runtime->obj);`
`44`	`43`	`_PyMem_Initialize(&runtime->mem);`