Skip to content

Commit 38f2ced

Browse files
flichtenheldcron2
authored andcommitted
ssl_verify: Change backend_x509_* functions to size_t for lengths
Fix conversion warnings without actual code changes. Change-Id: If971006b6d3a1a93d87b29627d91dd72faf5ceb2 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Gert Doering <gert@greenie.muc.de> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1138 Message-Id: <20250922204329.23460-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33152.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
1 parent e256d66 commit 38f2ced

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/openvpn/ssl_verify_backend.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ struct buffer x509_get_sha256_fingerprint(openvpn_x509_cert_t *cert, struct gc_a
123123
*
124124
* @return \c FAILURE, \c or SUCCESS
125125
*/
126-
result_t backend_x509_get_username(char *common_name, int cn_len, char *x509_username_field,
126+
result_t backend_x509_get_username(char *common_name, size_t cn_len, char *x509_username_field,
127127
openvpn_x509_cert_t *peer_cert);
128128

129129
#ifdef ENABLE_X509ALTUSERNAME

src/openvpn/ssl_verify_mbedtls.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ verify_callback(void *session_obj, mbedtls_x509_crt *cert, int cert_depth, uint3
128128
#endif
129129

130130
result_t
131-
backend_x509_get_username(char *cn, int cn_len, char *x509_username_field, mbedtls_x509_crt *cert)
131+
backend_x509_get_username(char *cn, size_t cn_len, char *x509_username_field, mbedtls_x509_crt *cert)
132132
{
133133
mbedtls_x509_name *name;
134134

src/openvpn/ssl_verify_openssl.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ x509_username_field_ext_supported(const char *fieldname)
120120
}
121121

122122
static bool
123-
extract_x509_extension(X509 *cert, char *fieldname, char *out, int size)
123+
extract_x509_extension(X509 *cert, char *fieldname, char *out, size_t size)
124124
{
125125
bool retval = false;
126126
char *buf = 0;
@@ -195,7 +195,7 @@ extract_x509_extension(X509 *cert, char *fieldname, char *out, int size)
195195
* to contain result is grounds for error).
196196
*/
197197
static result_t
198-
extract_x509_field_ssl(X509_NAME *x509, const char *field_name, char *out, int size)
198+
extract_x509_field_ssl(X509_NAME *x509, const char *field_name, char *out, size_t size)
199199
{
200200
int lastpos = -1;
201201
int tmp = -1;
@@ -252,7 +252,7 @@ extract_x509_field_ssl(X509_NAME *x509, const char *field_name, char *out, int s
252252
}
253253

254254
result_t
255-
backend_x509_get_username(char *common_name, int cn_len, char *x509_username_field, X509 *peer_cert)
255+
backend_x509_get_username(char *common_name, size_t cn_len, char *x509_username_field, X509 *peer_cert)
256256
{
257257
#ifdef ENABLE_X509ALTUSERNAME
258258
if (strncmp("ext:", x509_username_field, 4) == 0)

0 commit comments

Comments
 (0)