Skip to content

Commit b39a59c

Browse files
authored
Merge pull request NginxProxyManager#1045 from jc21/nginx-full
Switch to nginx-full base
2 parents ba5f0c2 + 9872daf commit b39a59c

File tree

3 files changed

+36
-34
lines changed

3 files changed

+36
-34
lines changed

docker/Dockerfile

+25-19
Original file line numberDiff line numberDiff line change
@@ -3,49 +3,55 @@
33

44
# This file assumes that the frontend has been built using ./scripts/frontend-build
55

6-
FROM --platform=${TARGETPLATFORM:-linux/amd64} jc21/alpine-nginx-full:node
6+
FROM --platform=${TARGETPLATFORM:-linux/amd64} jc21/nginx-full:node
77

88
ARG TARGETPLATFORM
99
ARG BUILDPLATFORM
1010
ARG BUILD_VERSION
1111
ARG BUILD_COMMIT
1212
ARG BUILD_DATE
1313

14-
ENV SUPPRESS_NO_CONFIG_WARNING=1
15-
ENV S6_FIX_ATTRS_HIDDEN=1
16-
ENV S6_BEHAVIOUR_IF_STAGE2_FAILS=1
17-
ENV NODE_ENV=production
14+
ENV SUPPRESS_NO_CONFIG_WARNING=1 \
15+
S6_FIX_ATTRS_HIDDEN=1 \
16+
S6_BEHAVIOUR_IF_STAGE2_FAILS=1 \
17+
NODE_ENV=production \
18+
NPM_BUILD_VERSION="${BUILD_VERSION}" \
19+
NPM_BUILD_COMMIT="${BUILD_COMMIT}" \
20+
NPM_BUILD_DATE="${BUILD_DATE}"
1821

1922
RUN echo "fs.file-max = 65535" > /etc/sysctl.conf \
20-
&& apk update \
21-
&& apk add python3 certbot jq \
22-
&& python3 -m ensurepip \
23-
&& rm -rf /var/cache/apk/*
24-
25-
ENV NPM_BUILD_VERSION="${BUILD_VERSION}" NPM_BUILD_COMMIT="${BUILD_COMMIT}" NPM_BUILD_DATE="${BUILD_DATE}"
23+
&& apt-get update \
24+
&& apt-get install -y certbot jq python3-pip \
25+
&& apt-get clean \
26+
&& rm -rf /var/lib/apt/lists/*
2627

2728
# s6 overlay
2829
COPY scripts/install-s6 /tmp/install-s6
2930
RUN /tmp/install-s6 "${TARGETPLATFORM}" && rm -f /tmp/install-s6
3031

31-
EXPOSE 80
32-
EXPOSE 81
33-
EXPOSE 443
32+
EXPOSE 80 81 443
3433

35-
ADD backend /app
36-
ADD frontend/dist /app/frontend
37-
COPY global /app/global
34+
COPY backend /app
35+
COPY frontend/dist /app/frontend
36+
COPY global /app/global
3837

3938
WORKDIR /app
4039
RUN yarn install
4140

4241
# add late to limit cache-busting by modifications
43-
COPY docker/rootfs /
42+
COPY docker/rootfs /
4443

4544
# Remove frontend service not required for prod, dev nginx config as well
4645
RUN rm -rf /etc/services.d/frontend RUN rm -f /etc/nginx/conf.d/dev.conf
4746

4847
VOLUME [ "/data", "/etc/letsencrypt" ]
4948
ENTRYPOINT [ "/init" ]
50-
5149
HEALTHCHECK --interval=5s --timeout=3s CMD /bin/check-health
50+
51+
LABEL org.label-schema.schema-version="1.0" \
52+
org.label-schema.license="MIT" \
53+
org.label-schema.name="nginx-proxy-manager" \
54+
org.label-schema.description="Docker container for managing Nginx proxy hosts with a simple, powerful interface " \
55+
org.label-schema.url="https://github.com/jc21/nginx-proxy-manager" \
56+
org.label-schema.vcs-url="https://github.com/jc21/nginx-proxy-manager.git" \
57+
org.label-schema.cmd="docker run --rm -ti jc21/nginx-proxy-manager:latest"

docker/dev/Dockerfile

+10-14
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
FROM jc21/alpine-nginx-full:node
1+
FROM jc21/nginx-full:node
22
LABEL maintainer="Jamie Curnow <jc@jc21.com>"
33

4-
ENV S6_LOGGING=0
5-
ENV SUPPRESS_NO_CONFIG_WARNING=1
6-
ENV S6_FIX_ATTRS_HIDDEN=1
4+
ENV S6_LOGGING=0 \
5+
SUPPRESS_NO_CONFIG_WARNING=1 \
6+
S6_FIX_ATTRS_HIDDEN=1
77

88
RUN echo "fs.file-max = 65535" > /etc/sysctl.conf \
9-
&& apk update \
10-
&& apk add python3 certbot jq \
11-
&& python3 -m ensurepip \
12-
&& rm -rf /var/cache/apk/*
9+
&& apt-get update \
10+
&& apt-get install -y certbot jq python3-pip \
11+
&& apt-get clean \
12+
&& rm -rf /var/lib/apt/lists/*
1313

1414
# Task
1515
RUN cd /usr \
@@ -23,10 +23,6 @@ RUN rm -f /etc/nginx/conf.d/production.conf
2323
RUN curl -L -o /tmp/s6-overlay-amd64.tar.gz "https://github.com/just-containers/s6-overlay/releases/download/v1.22.1.0/s6-overlay-amd64.tar.gz" \
2424
&& tar -xzf /tmp/s6-overlay-amd64.tar.gz -C /
2525

26-
EXPOSE 80
27-
EXPOSE 81
28-
EXPOSE 443
29-
26+
EXPOSE 80 81 443
3027
ENTRYPOINT [ "/init" ]
31-
32-
HEALTHCHECK --interval=5s --timeout=3s CMD /bin/check-health
28+
HEALTHCHECK --interval=5s --timeout=3s CMD /bin/check-health

scripts/frontend-build

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
44
. "$DIR/.common.sh"
55

6-
DOCKER_IMAGE=jc21/alpine-nginx-full:node
6+
DOCKER_IMAGE=jc21/nginx-full:node
77

88
# Ensure docker exists
99
if hash docker 2>/dev/null; then

0 commit comments

Comments
 (0)