Skip to content

Commit cae4806

Browse files
authoredFeb 7, 2025
Merge pull request #5113 from martin-frbg/issue5112
Ensure that GEMMTR name appears in XERBLA if GEMMT was called as such
2 parents c139b63 + db7e5f1 commit cae4806

File tree

3 files changed

+36
-14
lines changed

3 files changed

+36
-14
lines changed
 

‎interface/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ endif ()
109109
GenerateNamedObjects("trsm.c" "TRMM" "trmm" ${CBLAS_FLAG})
110110

111111
# gemmtr is gemmt under the name adopted by the Reference BLAS
112-
GenerateNamedObjects("gemm.c" "" "gemmtr" ${CBLAS_FLAG})
112+
GenerateNamedObjects("gemm.c" "RNAME" "gemmtr" ${CBLAS_FLAG})
113113

114114
# max and imax are compiled 4 times
115115
GenerateNamedObjects("max.c" "" "" ${CBLAS_FLAG})
@@ -126,7 +126,7 @@ if (BUILD_BFLOAT16)
126126
GenerateNamedObjects("bf16dot.c" "" "sbdot" ${CBLAS_FLAG} "" "" true "BFLOAT16")
127127
GenerateNamedObjects("gemm.c" "" "sbgemm" ${CBLAS_FLAG} "" "" true "BFLOAT16")
128128
GenerateNamedObjects("gemmt.c" "" "sbgemmt" ${CBLAS_FLAG} "" "" true "BFLOAT16")
129-
GenerateNamedObjects("gemmt.c" "" "sbgemmtr" ${CBLAS_FLAG} "" "" true "BFLOAT16")
129+
GenerateNamedObjects("gemmt.c" "RNAME" "sbgemmtr" ${CBLAS_FLAG} "" "" true "BFLOAT16")
130130
GenerateNamedObjects("sbgemv.c" "" "sbgemv" ${CBLAS_FLAG} "" "" true "BFLOAT16")
131131
GenerateNamedObjects("tobf16.c" "SINGLE_PREC" "sbstobf16" ${CBLAS_FLAG} "" "" true "BFLOAT16")
132132
GenerateNamedObjects("tobf16.c" "DOUBLE_PREC" "sbdtobf16" ${CBLAS_FLAG} "" "" true "BFLOAT16")

‎interface/Makefile

+12-12
Original file line numberDiff line numberDiff line change
@@ -1304,9 +1304,9 @@ ifeq ($(BUILD_BFLOAT16),1)
13041304
sbgemm.$(SUFFIX) sbgemm.$(PSUFFIX) : gemm.c ../param.h
13051305
$(CC) -c $(CFLAGS) $< -o $(@F)
13061306
sbgemmt.$(SUFFIX) sbgemmt.$(PSUFFIX) : sbgemmt.c ../param.h
1307-
$(CC) -c $(CFLAGS) $< -o $(@F)
1307+
$(CC) -c $(CFLAGS) -URNAME $< -o $(@F)
13081308
sbgemmtr.$(SUFFIX) sbgemmtr.$(PSUFFIX) : sbgemmt.c ../param.h
1309-
$(CC) -c $(CFLAGS) $< -o $(@F)
1309+
$(CC) -c $(CFLAGS) -DRNAME $< -o $(@F)
13101310
endif
13111311

13121312
sgemm.$(SUFFIX) sgemm.$(PSUFFIX) : gemm.c ../param.h
@@ -1328,34 +1328,34 @@ xgemm.$(SUFFIX) xgemm.$(PSUFFIX) : gemm.c ../param.h
13281328
$(CC) -c $(CFLAGS) $< -o $(@F)
13291329

13301330
sgemmt.$(SUFFIX) sgemmt.$(PSUFFIX) : gemmt.c ../param.h
1331-
$(CC) -c $(CFLAGS) $< -o $(@F)
1331+
$(CC) -c $(CFLAGS) -URNAME $< -o $(@F)
13321332

13331333
dgemmt.$(SUFFIX) dgemmt.$(PSUFFIX) : gemmt.c ../param.h
1334-
$(CC) -c $(CFLAGS) $< -o $(@F)
1334+
$(CC) -c $(CFLAGS) -URNAME $< -o $(@F)
13351335

13361336
qgemmt.$(SUFFIX) qgemmt.$(PSUFFIX) : gemmt.c ../param.h
1337-
$(CC) -c $(CFLAGS) $< -o $(@F)
1337+
$(CC) -c $(CFLAGS) -URNAME $< -o $(@F)
13381338

13391339
cgemmt.$(SUFFIX) cgemmt.$(PSUFFIX) : gemmt.c ../param.h
1340-
$(CC) -c $(CFLAGS) $< -o $(@F)
1340+
$(CC) -c $(CFLAGS) -URNAME $< -o $(@F)
13411341

13421342
zgemmt.$(SUFFIX) zgemmt.$(PSUFFIX) : gemmt.c ../param.h
1343-
$(CC) -c $(CFLAGS) $< -o $(@F)
1343+
$(CC) -c $(CFLAGS) -URNAME $< -o $(@F)
13441344

13451345
sgemmtr.$(SUFFIX) sgemmtr.$(PSUFFIX) : gemmt.c ../param.h
1346-
$(CC) -c $(CFLAGS) $< -o $(@F)
1346+
$(CC) -c $(CFLAGS) -DRNAME $< -o $(@F)
13471347

13481348
dgemmtr.$(SUFFIX) dgemmtr.$(PSUFFIX) : gemmt.c ../param.h
1349-
$(CC) -c $(CFLAGS) $< -o $(@F)
1349+
$(CC) -c $(CFLAGS) -DRNAME $< -o $(@F)
13501350

13511351
qgemmtr.$(SUFFIX) qgemmtr.$(PSUFFIX) : gemmt.c ../param.h
1352-
$(CC) -c $(CFLAGS) $< -o $(@F)
1352+
$(CC) -c $(CFLAGS) -DRNAME $< -o $(@F)
13531353

13541354
cgemmtr.$(SUFFIX) cgemmtr.$(PSUFFIX) : gemmt.c ../param.h
1355-
$(CC) -c $(CFLAGS) $< -o $(@F)
1355+
$(CC) -c $(CFLAGS) -DRNAME $< -o $(@F)
13561356

13571357
zgemmtr.$(SUFFIX) zgemmtr.$(PSUFFIX) : gemmt.c ../param.h
1358-
$(CC) -c $(CFLAGS) $< -o $(@F)
1358+
$(CC) -c $(CFLAGS) -DRNAME $< -o $(@F)
13591359

13601360
ssymm.$(SUFFIX) ssymm.$(PSUFFIX) : symm.c
13611361
$(CC) -c $(CFLAGS) $< -o $(@F)

‎interface/gemmt.c

+22
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@
3838

3939
#ifndef COMPLEX
4040
#define SMP_THRESHOLD_MIN 65536.0
41+
#ifdef RNAME
42+
#ifdef XDOUBLE
43+
#define ERROR_NAME "QGEMMTR"
44+
#elif defined(DOUBLE)
45+
#define ERROR_NAME "DGEMMTR"
46+
#elif defined(BFLOAT16)
47+
#define ERROR_NAME "SBGEMMTR"
48+
#else
49+
#define ERROR_NAME "SGEMMTR"
50+
#endif
51+
#else
4152
#ifdef XDOUBLE
4253
#define ERROR_NAME "QGEMMT "
4354
#elif defined(DOUBLE)
@@ -47,8 +58,18 @@
4758
#else
4859
#define ERROR_NAME "SGEMMT "
4960
#endif
61+
#endif
5062
#else
5163
#define SMP_THRESHOLD_MIN 8192.0
64+
#ifdef RNAME
65+
#ifdef XDOUBLE
66+
#define ERROR_NAME "XGEMMTR"
67+
#elif defined(DOUBLE)
68+
#define ERROR_NAME "ZGEMMTR"
69+
#else
70+
#define ERROR_NAME "CGEMMTR"
71+
#endif
72+
#else
5273
#ifdef XDOUBLE
5374
#define ERROR_NAME "XGEMMT "
5475
#elif defined(DOUBLE)
@@ -57,6 +78,7 @@
5778
#define ERROR_NAME "CGEMMT "
5879
#endif
5980
#endif
81+
#endif
6082

6183
#ifndef GEMM_MULTITHREAD_THRESHOLD
6284
#define GEMM_MULTITHREAD_THRESHOLD 4

0 commit comments

Comments
 (0)
Please sign in to comment.