Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OneSignal/OneSignal-iOS-SDK
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: OneSignal/OneSignal-iOS-SDK
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.4.0_beta_branch
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 311 files changed
  • 1 contributor

Commits on Aug 2, 2025

  1. Add custom events feature

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    fa20772 View commit details
    Browse the repository at this point in the history

  2. [nits] improve string description of OneSignalClientError 

    Motivation:
- previously it would log like this: "request failed with error: <OneSignalClientError: 0x600000cd49c0>
- now it will log like this: "request failed with error: <OneSignalClientError code: 202, message: Error parsing JSON, response: (null), underlyingError: Error Domain=NSCocoaErrorDomain Code=3840 "JSON text did not start with array or object and option to allow fragments not set. around line 1, column 0." UserInfo={NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set. around line 1, column 0., NSJSONSerializationErrorIndex=0} >"
    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    69d4e54 View commit details
    Browse the repository at this point in the history

  3. [nits] privatize internal methods 

    * No need to be on protocol nor exposed
    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    7c215c3 View commit details
    Browse the repository at this point in the history

  4. Create executor to handle custom events

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    b1cf15f View commit details
    Browse the repository at this point in the history

  5. [dev app] Add custom events examples 

    * Add 2 buttons at the bottom of Dev App called "Track Named Event" for making a named event yourself and the other button "Track Preset Custom Events" sends a misc collection of events with different payloads
* Add example custom events in Objective-C and Swift
    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    3601dd3 View commit details
    Browse the repository at this point in the history

  6. update the endpoint used for events

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    69cfe85 View commit details
    Browse the repository at this point in the history

  7. Update endpoint used for custom events

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    e87567c View commit details
    Browse the repository at this point in the history

  8. Don't batch custom events

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    5c240dc View commit details
    Browse the repository at this point in the history

  9. release commit 5.4.0-alpha-01

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    e5a55d1 View commit details
    Browse the repository at this point in the history

  10. release: build all frameworks

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    af6e39b View commit details
    Browse the repository at this point in the history

  11. release: codesign

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    e96fa88 View commit details
    Browse the repository at this point in the history

  12. ./update_swift_package.s

    @nan-li
    nan-li committed Aug 2, 2025
    Configuration menu
    Copy the full SHA
    675ebba View commit details
    Browse the repository at this point in the history

  13. Merge pull request #1584 from OneSignal/release/5.4.0-alpha-01 

    Release 5.4.0-alpha-01
    @nan-li
    nan-li authored Aug 2, 2025
    Configuration menu
    Copy the full SHA
    4e40f14 View commit details
    Browse the repository at this point in the history
Loading