Merge pull request swiftlang#2074 from millenomi/bundle-allbundles

Parity: Bundle.allBundles/.allFrameworks

Author: millenomi

Diff for: CoreFoundation/Base.subproj/ForSwiftFoundationOnly.h

@@ -391,6 +391,7 @@ CF_EXPORT _Nullable CFErrorRef CFReadStreamCopyError(CFReadStreamRef _Null_unspe
 
 CF_EXPORT _Nullable CFErrorRef CFWriteStreamCopyError(CFWriteStreamRef _Null_unspecified stream);
 
+CF_CROSS_PLATFORM_EXPORT CFStringRef _Nullable _CFBundleCopyExecutablePath(CFBundleRef bundle);
 CF_CROSS_PLATFORM_EXPORT Boolean _CFBundleSupportsFHSBundles(void);
 
 // https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

Diff for: CoreFoundation/PlugIn.subproj/CFBundle.c

@@ -951,7 +951,11 @@ CF_PRIVATE CFURLRef _CFBundleCopyAppStoreReceiptURLInDirectory(CFURLRef bundleUR
 CFURLRef _CFBundleCopyAppStoreReceiptURL(CFBundleRef bundle) {
     return _CFBundleCopyAppStoreReceiptURLInDirectory(bundle->_url, bundle->_version);
 }
-        
+
+CF_CROSS_PLATFORM_EXPORT CFStringRef _CFBundleCopyExecutablePath(CFBundleRef bundle) {
+    return _CFBundleCopyExecutableName(bundle, NULL, NULL);
+}
+
 CF_PRIVATE CFStringRef _CFBundleCopyExecutableName(CFBundleRef bundle, CFURLRef url, CFDictionaryRef infoDict) {
     CFStringRef executableName = NULL;
 

Diff for: Foundation/Bundle.swift

@@ -22,10 +22,41 @@ open class Bundle: NSObject {
         }
     }
 
-    open class var allBundles: [Bundle] {
-        NSUnimplemented()
+    private class var allBundlesRegardlessOfType: [Bundle] {
+        // FIXME: This doesn't return bundles that weren't loaded using CFBundle or class Bundle. https://bugs.swift.org/browse/SR-10433
+        guard let bundles = CFBundleGetAllBundles()?._swiftObject as? [CFBundle] else { return [] }
+        return bundles.map(Bundle.init(cfBundle:))
     }
 
+    private var isFramework: Bool {
+        #if os(macOS) || os(iOS) || os(watchOS) || os(tvOS)
+        return bundleURL.pathExtension == "framework"
+        #else
+        
+            #if os(Windows)
+            if let name = _CFBundleCopyExecutablePath(_bundle)?._nsObject {
+                return name.pathExtension.lowercased == "dll"
+            }
+            #else
+        
+            // We're assuming this is an OS like Linux or BSD that uses FHS-style library names (lib….so or lib….so.2.3.4)
+            if let name = _CFBundleCopyExecutablePath(_bundle)?._nsObject {
+                return name.hasPrefix("lib") && (name.pathExtension == "so" || name.range(of: ".so.").location != NSNotFound)
+            }
+        
+            #endif
+        
+        return false
+        #endif
+    }
+    
+    open class var allBundles: [Bundle] {
+        return allBundlesRegardlessOfType.filter { !$0.isFramework }
+    }
+    
+    open class var allFrameworks: [Bundle] {
+        return allBundlesRegardlessOfType.filter { $0.isFramework }
+    }
 
     internal init(cfBundle: CFBundle) {
         super.init()