Foundation: make FileManager build on Windows again

Windows should use `SetFileTime` for adjusting the file times.  More
importantly, it does not support `time_t` so the signature of the POSIX
functions are different.  Factor out the file time adjustment into a
helper that is implemented in the POSIX/Win32 layer and use that
instead.

Author: compnerd

Diff for: Foundation/FileManager+POSIX.swift

@@ -1159,6 +1159,32 @@ internal func _contentsEqual(atPath path1: String, andPath path2: String) -> Boo
             return nil
         }
     }
+
+    internal func _updateTimes(atPath path: String, withFileSystemRepresentation fsr: UnsafePointer<Int8>, creationTime: Date? = nil, accessTime: Date? = nil, modificationTime: Date? = nil) throws {
+        let stat = try _lstatFile(atPath: path, withFileSystemRepresentation: fsr)
+
+        let accessDate = accessTime ?? stat.lastAccessDate
+        let modificationDate = modificationTime ?? stat.lastModificationDate
+
+        let (accessTimeSince1970Seconds, accessTimeSince1970FractionsOfSecond) = modf(accessDate.timeIntervalSince1970)
+        let accessTimeval = timeval(tv_sec: time_t(accessTimeSince1970Seconds), tv_usec: suseconds_t(1.0e9 * accessTimeSince1970FractionsOfSecond))
+
+        let (modificationTimeSince1970Seconds, modificationTimeSince1970FractionsOfSecond) = modf(modificationDate.timeIntervalSince1970)
+        let modificationTimeval = timeval(tv_sec: time_t(modificationTimeSince1970Seconds), tv_usec: suseconds_t(1.0e9 * modificationTimeSince1970FractionsOfSecond))
+
+        let array = [accessTimeval, modificationTimeval]
+        let errnoValue = array.withUnsafeBufferPointer { (bytes) -> Int32? in
+            if utimes(fsr, bytes.baseAddress) < 0 {
+                return errno
+            } else {
+                return nil
+            }
+        }
+
+        if let error = errnoValue {
+            throw _NSErrorWithErrno(error, reading: false, path: path)
+        }
+    }
 }
 
 extension FileManager.NSPathDirectoryEnumerator {

Diff for: Foundation/FileManager+Win32.swift

@@ -605,6 +605,33 @@ extension FileManager {
         return temp._bridgeToObjectiveC().appendingPathComponent(dest)
     }
 
+    internal func _updateTimes(atPath path: String,
+                               withFileSystemRepresentation fsr: UnsafePointer<Int8>,
+                               creationTime: Date? = nil,
+                               accessTime: Date? = nil,
+                               modificationTime: Date? = nil) throws {
+      let stat = try _lstatFile(atPath: path, withFileSystemRepresentation: fsr)
+
+      var atime: FILETIME =
+          FILETIME(from: time_t((accessTime ?? stat.lastAccessDate).timeIntervalSince1970))
+      var mtime: FILETIME =
+          FILETIME(from: time_t((modificationTime ?? stat.lastModificationDate).timeIntervalSince1970))
+
+      let hFile: HANDLE = String(utf8String: fsr)!.withCString(encodedAs: UTF16.self) {
+        CreateFileW($0, DWORD(GENERIC_WRITE), DWORD(FILE_SHARE_WRITE),
+                    nil, DWORD(OPEN_EXISTING), 0, nil)
+      }
+      if hFile == INVALID_HANDLE_VALUE {
+        throw _NSErrorWithWindowsError(GetLastError(), reading: true)
+      }
+      defer { CloseHandle(hFile) }
+
+      if !SetFileTime(hFile, nil, &atime, &mtime) {
+        throw _NSErrorWithWindowsError(GetLastError(), reading: false)
+      }
+
+    }
+
     internal class NSURLDirectoryEnumerator : DirectoryEnumerator {
         var _options : FileManager.DirectoryEnumerationOptions
         var _errorHandler : ((URL, Error) -> Bool)?

Diff for: Foundation/FileManager.swift

@@ -371,32 +371,10 @@ open class FileManager : NSObject {
                     }
                 #endif
             }
-            
-            // Set dates as the very last step, to avoid other operations overwriting these values:
+
             if newModificationDate != nil || newAccessDate != nil {
-                let stat = try _lstatFile(atPath: path, withFileSystemRepresentation: fsRep)
-                
-                let accessDate = newAccessDate ?? stat.lastAccessDate
-                let modificationDate = newModificationDate ?? stat.lastModificationDate
-                
-                let (accessTimeSince1970Seconds, accessTimeSince1970FractionsOfSecond) = modf(accessDate.timeIntervalSince1970)
-                let accessTimeval = timeval(tv_sec: time_t(accessTimeSince1970Seconds), tv_usec: suseconds_t(1.0e9 * accessTimeSince1970FractionsOfSecond))
-                
-                let (modificationTimeSince1970Seconds, modificationTimeSince1970FractionsOfSecond) = modf(modificationDate.timeIntervalSince1970)
-                let modificationTimeval = timeval(tv_sec: time_t(modificationTimeSince1970Seconds), tv_usec: suseconds_t(1.0e9 * modificationTimeSince1970FractionsOfSecond))
-                
-                let array = [accessTimeval, modificationTimeval]
-                let errnoValue = array.withUnsafeBufferPointer { (bytes) -> Int32? in
-                    if utimes(fsRep, bytes.baseAddress) < 0 {
-                        return errno
-                    } else {
-                        return nil
-                    }
-                }
-                
-                if let error = errnoValue {
-                    throw _NSErrorWithErrno(error, reading: false, path: path)
-                }
+              // Set dates as the very last step, to avoid other operations overwriting these values:
+              try _updateTimes(atPath: path, withFileSystemRepresentation: fsRep, accessTime: newAccessDate, modificationTime: newModificationDate)
             }
         })
     }

Diff for: Foundation/NSURL.swift

@@ -1799,8 +1799,10 @@ fileprivate extension URLResourceValuesStorage {
                 result[key] = try attribute(.size)
             case .totalFileAllocatedSizeKey: fallthrough // FIXME: This should add the size of any metadata.
             case .fileAllocatedSizeKey:
+#if !os(Windows)
                 let stat = try urlStat()
                 result[key] = Int(stat.st_blocks) * Int(stat.st_blksize)
+#endif
             case .isAliasFileKey:
                 // swift-corelibs-foundation does not support aliases and bookmarks.
                 break
@@ -2042,7 +2044,7 @@ extension stat {
         #elseif os(Android)
         return Date(timeIntervalSince1970: st_mtime, nanoseconds: st_mtime_nsec)
         #elseif os(Windows)
-        return Date(timeIntervalSince1970: st_mtime)
+        return Date(timeIntervalSince1970: TimeInterval(st_mtime))
         #else
         return Date(timespec: st_mtim)
         #endif
@@ -2054,7 +2056,7 @@ extension stat {
         #elseif os(Android)
         return Date(timeIntervalSince1970: st_atime, nanoseconds: st_atime_nsec)
         #elseif os(Windows)
-        return Date(timeIntervalSince1970: st_atime)
+        return Date(timeIntervalSince1970: TimeInterval(st_atime))
         #else
         return Date(timespec: st_atim)
         #endif
@@ -2066,7 +2068,7 @@ extension stat {
         #elseif os(Android)
         return Date(timeIntervalSince1970: st_ctime, nanoseconds: st_ctime_nsec)
         #elseif os(Windows)
-        return Date(timeIntervalSince1970: st_ctime)
+        return Date(timeIntervalSince1970: TimeInterval(st_ctime))
         #else
         return Date(timespec: st_ctim)
         #endif