Skip to content

Commit 389fd15

Browse files
committed
allows hostname instead of ip for streams
1 parent 1a64d44 commit 389fd15

File tree

10 files changed

+60
-21
lines changed

10 files changed

+60
-21
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
const migrate_name = 'scream-domain';
2+
const logger = require('../logger').migrate;
3+
4+
/**
5+
* Migrate
6+
*
7+
* @see http://knexjs.org/#Schema
8+
*
9+
* @param {Object} knex
10+
* @param {Promise} Promise
11+
* @returns {Promise}
12+
*/
13+
exports.up = function (knex/*, Promise*/) {
14+
logger.info('[' + migrate_name + '] Migrating Up...');
15+
16+
return knex.schema.table('stream', (table) => {
17+
table.renameColumn('forward_ip', 'forwarding_host');
18+
})
19+
.then(function () {
20+
logger.info('[' + migrate_name + '] stream Table altered');
21+
});
22+
};
23+
24+
/**
25+
* Undo Migrate
26+
*
27+
* @param {Object} knex
28+
* @param {Promise} Promise
29+
* @returns {Promise}
30+
*/
31+
exports.down = function (knex/*, Promise*/) {
32+
logger.info('[' + migrate_name + '] Migrating Down...');
33+
34+
return knex.schema.table('stream', (table) => {
35+
table.renameColumn('forwarding_host', 'forward_ip');
36+
})
37+
.then(function () {
38+
logger.info('[' + migrate_name + '] stream Table altered');
39+
});
40+
};

backend/schema/endpoints/streams.json

+10-9
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@
2020
"minimum": 1,
2121
"maximum": 65535
2222
},
23-
"forward_ip": {
23+
"forwarding_host": {
2424
"type": "string",
25-
"format": "ipv4"
25+
"minLength": 1,
26+
"maxLength": 255
2627
},
2728
"forwarding_port": {
2829
"type": "integer",
@@ -55,8 +56,8 @@
5556
"incoming_port": {
5657
"$ref": "#/definitions/incoming_port"
5758
},
58-
"forward_ip": {
59-
"$ref": "#/definitions/forward_ip"
59+
"forwarding_host": {
60+
"$ref": "#/definitions/forwarding_host"
6061
},
6162
"forwarding_port": {
6263
"$ref": "#/definitions/forwarding_port"
@@ -107,15 +108,15 @@
107108
"additionalProperties": false,
108109
"required": [
109110
"incoming_port",
110-
"forward_ip",
111+
"forwarding_host",
111112
"forwarding_port"
112113
],
113114
"properties": {
114115
"incoming_port": {
115116
"$ref": "#/definitions/incoming_port"
116117
},
117-
"forward_ip": {
118-
"$ref": "#/definitions/forward_ip"
118+
"forwarding_host": {
119+
"$ref": "#/definitions/forwarding_host"
119120
},
120121
"forwarding_port": {
121122
"$ref": "#/definitions/forwarding_port"
@@ -154,8 +155,8 @@
154155
"incoming_port": {
155156
"$ref": "#/definitions/incoming_port"
156157
},
157-
"forward_ip": {
158-
"$ref": "#/definitions/forward_ip"
158+
"forwarding_host": {
159+
"$ref": "#/definitions/forwarding_host"
159160
},
160161
"forwarding_port": {
161162
"$ref": "#/definitions/forwarding_port"

backend/templates/stream.conf

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ server {
1212
#listen [::]:{{ incoming_port }};
1313
{% endif %}
1414

15-
proxy_pass {{ forward_ip }}:{{ forwarding_port }};
15+
proxy_pass {{ forwarding_host }}:{{ forwarding_port }};
1616

1717
# Custom
1818
include /data/nginx/custom/server_stream[.]conf;
@@ -27,7 +27,7 @@ server {
2727
{% else -%}
2828
#listen [::]:{{ incoming_port }} udp;
2929
{% endif %}
30-
proxy_pass {{ forward_ip }}:{{ forwarding_port }};
30+
proxy_pass {{ forwarding_host }}:{{ forwarding_port }};
3131

3232
# Custom
3333
include /data/nginx/custom/server_stream[.]conf;

docker/rootfs/etc/services.d/frontend/run

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
if [ "$DEVELOPMENT" == "true" ]; then
66
cd /app/frontend || exit 1
7+
# If yarn install fails: add --verbose --network-concurrency 1
78
yarn install
89
yarn watch
910
else

docker/rootfs/etc/services.d/manager/run

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ cd /app || echo
66

77
if [ "$DEVELOPMENT" == "true" ]; then
88
cd /app || exit 1
9+
# If yarn install fails: add --verbose --network-concurrency 1
910
yarn install
1011
node --max_old_space_size=250 --abort_on_uncaught_exception node_modules/nodemon/bin/nodemon.js
1112
else

frontend/js/app/nginx/stream/form.ejs

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
</div>
1515
<div class="col-sm-8 col-md-8">
1616
<div class="form-group">
17-
<label class="form-label"><%- i18n('streams', 'forward-ip') %><span class="form-required">*</span></label>
18-
<input type="text" name="forward_ip" class="form-control text-monospace" placeholder="000.000.000.000" value="<%- forward_ip %>" autocomplete="off" maxlength="15" required>
17+
<label class="form-label"><%- i18n('streams', 'forwarding-host') %><span class="form-required">*</span></label>
18+
<input type="text" name="forwarding_host" class="form-control text-monospace" value="<%- forwarding_host %>" autocomplete="off" required>
1919
</div>
2020
</div>
2121
<div class="col-sm-4 col-md-4">

frontend/js/app/nginx/stream/form.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module.exports = Mn.View.extend({
1313

1414
ui: {
1515
form: 'form',
16-
forward_ip: 'input[name="forward_ip"]',
16+
forwarding_host: 'input[name="forwarding_host"]',
1717
type_error: '.forward-type-error',
1818
buttons: '.modal-footer button',
1919
switches: '.custom-switch-input',
@@ -77,10 +77,6 @@ module.exports = Mn.View.extend({
7777
},
7878

7979
onRender: function () {
80-
this.ui.forward_ip.mask('099.099.099.099', {
81-
clearIfNotMatch: true,
82-
placeholder: '000.000.000.000'
83-
});
8480
},
8581

8682
initialize: function (options) {

frontend/js/app/nginx/stream/list/item.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
</div>
1313
</td>
1414
<td>
15-
<div class="text-monospace"><%- forward_ip %>:<%- forwarding_port %></div>
15+
<div class="text-monospace"><%- forwarding_host %>:<%- forwarding_port %></div>
1616
</td>
1717
<td>
1818
<div>

frontend/js/i18n/messages.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@
162162
"add": "Add Stream",
163163
"form-title": "{id, select, undefined{New} other{Edit}} Stream",
164164
"incoming-port": "Incoming Port",
165-
"forward-ip": "Forward IP",
165+
"forwarding-host": "Forward Host",
166166
"forwarding-port": "Forward Port",
167167
"tcp-forwarding": "TCP Forwarding",
168168
"udp-forwarding": "UDP Forwarding",

frontend/js/models/stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const model = Backbone.Model.extend({
99
created_on: null,
1010
modified_on: null,
1111
incoming_port: null,
12-
forward_ip: null,
12+
forwarding_host: null,
1313
forwarding_port: null,
1414
tcp_forwarding: true,
1515
udp_forwarding: false,

0 commit comments

Comments
 (0)