Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: NattyNarwhal/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: session-sapi-api
Choose a head ref
  • 8 commits
  • 3 files changed
  • 1 contributor

Commits on Jul 21, 2025

  1. Add SAPI_HEADER_DELETE_PREFIX operation 

    The session ext currently munges into the linked list of headers
itself, because the delete header API is given the key for headers to
delete. The session ext wants to use a prefix past the colon separator,
for i.e. "Set-Cookie: PHPSESSID=", to eliminate only the specific cookie
rather than all cookies.

This changes the SAPI code to add a new header op to take a prefix
instead. Call sites are yet unchanged. Also fix some whitespace.
    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    e7c3bf7 View commit details
    Browse the repository at this point in the history

  2. Simplify cookie setting code in ext/session 

    Use the modern SAPI header ops API, including the remove prefix op we
just added.
    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    afc1c24 View commit details
    Browse the repository at this point in the history

  3. [ci skip] Remove redundant and unnecessary comment 

    The purpose of this is clear, and after refactoring, the special case is
no longer there, so it has no value.
    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    c636d66 View commit details
    Browse the repository at this point in the history

  4. Un-deprecate simple add/replace header API, use it 

    Suggestion from Jakub.
    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    8a2713f View commit details
    Browse the repository at this point in the history

  5. Restore the optimization removing session cookies had 

    I don't think this needs to be special cased with the parameter.
    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    f263bf1 View commit details
    Browse the repository at this point in the history

  6. Move setting header length to caller 

    Suggestion from Jakub.
    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    284132a View commit details
    Browse the repository at this point in the history

  7. [ci skip] adjust tab count 

    It may be better to use spaces in here instead.
    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    926fa17 View commit details
    Browse the repository at this point in the history

  8. Use session_cookie_len rather than calling strlen

    @NattyNarwhal
    NattyNarwhal committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    e2b3ce7 View commit details
    Browse the repository at this point in the history
Loading