Skip to content

Commit 268593a

Browse files
committed
Always invoke build script for WebKit and MetadataGenerator targets
They manage their dependencies correctly and do not rebuild anything when no changes are made. With the current scheme these are being built only once after the project is generated and never again until the timestamps files are removed. If you change anything or have another reason to rebuild, you have to manually delete the timestamps.
1 parent 7a5e27c commit 268593a

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/MetadataGenerator.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ ExternalProject_Add(MetadataGenerator
55
-DCMAKE_INSTALL_PREFIX=${CMAKE_BINARY_DIR}/metadataGenerator
66
-DCMAKE_BUILD_TYPE=$<CONFIG>
77
"${CMAKE_SOURCE_DIR}/src/metadata-generator"
8+
9+
BUILD_ALWAYS 1
810
BUILD_COMMAND env -i "${CMAKE_COMMAND}"
911
--build .
1012
--target install

src/WebKit.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ ExternalProject_Add(
5858
SOURCE_DIR ${WEBKIT_SOURCE_DIR}
5959
CMAKE_GENERATOR ${CMAKE_GENERATOR}
6060
CMAKE_ARGS ${WEBKIT_CMAKE_ARGS}
61+
BUILD_ALWAYS 1
6162
BUILD_COMMAND ${CMAKE_SOURCE_DIR}/build/scripts/build-step-webkit.sh
6263
INSTALL_COMMAND ""
6364
)

0 commit comments

Comments
 (0)