Skip to content

Commit a0793db

Browse files
mayunhaiPanJiaChen
authored andcommitted
fix[ImageCropper]: removeEventListener when destroyed(PanJiaChen#2169)
1 parent 9538d1b commit a0793db

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/components/ImageCropper/index.vue

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -839,16 +839,20 @@ export default {
839839
that.$emit('crop-upload-fail', err, field, ki)
840840
}
841841
})
842+
},
843+
closeHandler(e) {
844+
if (this.value && (e.key == 'Escape' || e.keyCode == 27)) {
845+
this.off()
846+
}
842847
}
843848
},
844849
created() {
845850
// 绑定按键esc隐藏此插件事件
846-
document.addEventListener('keyup', (e) => {
847-
if (this.value && (e.key == 'Escape' || e.keyCode == 27)) {
848-
this.off()
849-
}
850-
})
851-
}
851+
document.addEventListener('keyup', this.closeHandler)
852+
},
853+
destroyed() {
854+
document.removeEventListener('keyup', this.closeHandler)
855+
},
852856
}
853857
</script>
854858

0 commit comments

Comments
 (0)