simplify a bit first

Author: ChrisRackauckas

src/systems/diffeqs/abstractodesystem.jl

@@ -55,7 +55,7 @@ function calculate_factorized_W(sys::AbstractODESystem, simplify=true)
     isempty(sys.Wfact[]) || return (sys.Wfact[],sys.Wfact_t[])
 
     jac = calculate_jacobian(sys)
-    gam = Variable(:gam; known = true)()
+    gam = Variable(gensym(:gamma))()
 
     W = - LinearAlgebra.I + gam*jac
     Wfact = lu(W, Val(false), check=false).factors

src/systems/diffeqs/modelingtoolkitize.jl

@@ -9,7 +9,7 @@ function modelingtoolkitize(prob::DiffEqBase.ODEProblem)
     @parameters t
     vars = [Variable(:x, i)(t) for i in eachindex(prob.u0)]
     params = prob.p isa DiffEqBase.NullParameters ? [] :
-             [Variable(:α,i; known = true)() for i in eachindex(prob.p)]
+             [Variable(:α,i)() for i in eachindex(prob.p)]
     @derivatives D'~t
 
     rhs = [D(var) for var in vars]
@@ -22,7 +22,7 @@ function modelingtoolkitize(prob::DiffEqBase.ODEProblem)
     end
 
     eqs = vcat([rhs[i] ~ lhs[i] for i in eachindex(prob.u0)]...)
-    de = ODESystem(eqs)
+    de = ODESystem(eqs,t,vars,params)
 
     de, vars, params
 end

test/variable_parsing.jl

@@ -17,9 +17,9 @@ z1 = Variable(:z)(t)
 end
 @parameters σ(..)
 
-t1 = Variable(:t; known = true)()
-s1 = Variable(:s; known = true)()
-σ1 = Variable(:σ; known = true)
+t1 = Variable(:t)()
+s1 = Variable(:s)()
+σ1 = Variable(:σ)
 @test isequal(t1, t)
 @test isequal(s1, s)
 @test isequal(σ1, σ)
@@ -42,12 +42,12 @@ convert(Expression, :($x == 0 ? $y : $x))
 end
 @parameters σ[1:2](..)
 
-t1 = [Variable(:t, 1; known = true)(),
-      Variable(:t, 2; known = true)()]
-s1 = [Variable(:s, 1, 1; known = true)() Variable(:s, 1, 2; known = true)()
-      Variable(:s, 3, 1; known = true)() Variable(:s, 3, 2; known = true)()]
-σ1 = [Variable(:σ, 1; known = true),
-      Variable(:σ, 2; known = true)]
+t1 = [Variable(:t, 1)(),
+      Variable(:t, 2)()]
+s1 = [Variable(:s, 1, 1)() Variable(:s, 1, 2)()
+      Variable(:s, 3, 1)() Variable(:s, 3, 2)()]
+σ1 = [Variable(:σ, 1),
+      Variable(:σ, 2)]
 @test isequal(t1, t)
 @test isequal(s1, s)
 @test isequal(σ1, σ)