Skip to content

Commit 394e95a

Browse files
authored
Merge pull request #1129 from BillWagner/semester-review
Bring dotnet contributor up to date
2 parents 951e2a3 + 9e2e820 commit 394e95a

10 files changed

+55
-195
lines changed

.openpublishing.redirection.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,11 @@
142142
},
143143
{
144144
"source_path": "Contribute/content/additional-resources.md",
145-
"redirect_url": "/contribute/content/index",
146-
"redirect_document_id": true
145+
"redirect_url": "/contribute/content/index"
147146
},
148147
{
149-
"source_path": "Contribute/dotnet/net-core-5-naming.md",
150-
"redirect_url": "/contribute/content/dotnet/net-core-5-naming",
151-
"redirect_document_id": true
148+
"source_path": "Contribute/content/dotnet/net-core-5-naming.md",
149+
"redirect_url": "/contribute/content/dotnet/dotnet-contribute"
152150
},
153151
{
154152
"source_path": "Contribute/get-started-setup-github.md",

Contribute/content/TOC.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@
103103
href: dotnet/dotnet-pr-review.md
104104
- name: Code analysis docs
105105
href: dotnet/dotnet-contribute-code-analysis.md
106-
- name: .NET naming in docs
107-
href: dotnet/net-core-5-naming.md
108106
- name: Patterns and Practices (AAC, WAF, CAF)
109107
href: architecture-center/aac-contribute.md
110108
- name: PowerShell-Docs

Contribute/content/dotnet/api-documentation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
title: How to write /// docs for .NET API ref
3-
ms.date: 06/29/2023
3+
ms.date: 06/17/2025
44
author: gewarren
55
ms.author: gewarren
66
ms.service: learn
@@ -9,7 +9,7 @@ description: Learn how to write good descriptions in source code for generating
99
---
1010
# How to write good /// docs for .NET API reference
1111

12-
The ultimate goal for .NET API docs is to have the /// XML comments in the .NET source code be the "source of truth". For MSBuild, ASP.NET Core, and EF Core, this goal has been met. However, currently the [dotnet-api-docs repo](https://github.com/dotnet/dotnet-api-docs) remains the source of truth for core .NET API reference. [This dotnet/runtime issue](https://github.com/dotnet/runtime/issues/44969) tracks the effort to backport .NET docs and make the [dotnet/runtime](https://github.com/dotnet/runtime) repo the source of truth.
12+
The ultimate goal for .NET API docs is to have the `///` XML comments in the .NET source code be the "source of truth". For MSBuild, ASP.NET Core, and EF Core, this goal has been met. However, currently the [dotnet-api-docs repo](https://github.com/dotnet/dotnet-api-docs) remains the source of truth for some namespaces in the .NET API reference. [This dotnet/runtime issue](https://github.com/dotnet/runtime/issues/44969) tracks the effort to backport .NET docs and make the [dotnet/runtime](https://github.com/dotnet/runtime) repo the source of truth. The presence or absence of the "edit" button on a page often indicates that the `dotnet-api-docs` repository is the source of truth. If it's missing, the source of truth is likely the `///` comments in the source repo.
1313

1414
This article provides tips about writing good doc comments *within the source code itself*.
1515

Contribute/content/dotnet/dotnet-contribute-code-analysis.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ ms.author: mavasani
66
ms.topic: contributor-guide
77
ms.service: learn
88
ms.custom: external-contributor-guide
9-
ms.date: 10/09/2020
9+
ms.date: 06/17/2025
1010
---
1111
# Contribute docs for .NET code analysis rules to the .NET docs repository
1212

Contribute/content/dotnet/dotnet-contribute.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: This article describes the process for contributing to the articles
44
ms.topic: contributor-guide
55
ms.service: learn
66
ms.custom: external-contributor-guide
7-
ms.date: 04/08/2021
7+
ms.date: 06/17/2025
88
---
99
# Contribute to the .NET documentation repositories
1010

@@ -15,10 +15,12 @@ This document covers the process for contributing to the articles and code sampl
1515
The .NET documentation site is built from multiple repositories. These are just some of them:
1616

1717
- [.NET conceptual articles and code snippets](https://github.com/dotnet/docs)
18+
- [ASP.NET Core conceptual documentation](https://github.com/dotnet/AspNetCore.Docs)
19+
- [.NET Aspire conceptual documentation](https://github.com/dotnet/docs-aspire)
20+
- [.NET Desktop conceptual documentation](https://github.com/dotnet/docs-desktop)
21+
- [.NET MAUI conceptual documentation](https://github.com/dotnet/docs-maui)
1822
- [Code samples and snippets](https://github.com/dotnet/samples)
1923
- [.NET API reference](https://github.com/dotnet/dotnet-api-docs)
20-
- [.NET Compiler Platform SDK reference](https://github.com/dotnet/roslyn-api-docs)
21-
- [ML.NET API reference](https://github.com/dotnet/ml-api-docs)
2224

2325
## Guidelines for contributions
2426

Contribute/content/dotnet/dotnet-pr-review.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: The .NET docs do not have the PR merger webhooks enabled. This arti
44
ms.topic: contributor-guide
55
ms.service: learn
66
ms.custom: external-contributor-guide
7-
ms.date: 06/24/2020
7+
ms.date: 06/17/2025
88
---
99
# Pull request review process for the .NET docs repositories
1010

@@ -31,20 +31,20 @@ Reviews follow one of the three paths based on the PR:
3131
- **Major contributions** - Major contributions are significant edits to an existing article, new articles, or edits to a number of articles.
3232
- **Work in progress** - Authors can can create a PR that is marked as not ready for review yet by opening a *draft* pull request.
3333

34-
The processing used by the Contributor License Agreement (CLA) bot is a good guideline for the distinction between "small" and "large" contributions. PRs that do not require the CLA to be signed are likely "small." PRs that do require the CLA are likely "large."
34+
The processing used by the Contributor License Agreement (CLA) bot is a good guideline for the distinction between "small" and "large" contributions. PRs that do not require the CLA to be signed are likely "small." PRs that do require the CLA are likely "large." The CLA needs to be signed once by each contributor, so this is an imperfect guide.
3535

3636
### Small PRs
3737

3838
The changes in small PRs are reviewed for accuracy and checked using the build on the review site. Because they are small, these PRs do not trigger a review of the entire article.
3939

40-
Reviewers may notice other small changes that would improve an article. If those changes are also small, suggest them as review comments. If the suggested changes would trigger a larger review, open an issue and address those later.
40+
Reviewers might notice other small changes that would improve an article. If those changes are also small, reviewers might suggest them as review comments. If the suggested changes would trigger a larger review, reviewers will ask to open an issue and address those later.
4141

4242
### Larger changes
4343

4444
Larger PRs undergo a more thorough review. The following are all checked:
4545

46-
- Sample code must be included in the PR, in source and as a downloadable zip file.
47-
- Sample code compiles and runs correctly.
46+
- Sample code must be included in the PR in source.
47+
- Sample code compiles and runs correctly using a supported .NET version.
4848
- The article clearly describes the goals for the reader, and those goals are met.
4949
- The article meets [style and grammar guidelines](dotnet-style-guide.md) and follows our [voice and tone principles](dotnet-voice-tone.md).
5050
- All links should resolve correctly.
@@ -59,7 +59,7 @@ You may want feedback earlier in the process. Open a draft PR and add a comment
5959

6060
## Explain suggestions
6161

62-
GitHub lets you enter comments in triple-back-tick blocks of type `suggestion` that are displayed as a diff and can be merged by clicking a button. On short lines, GitHub does a good job of highlighting the changes. On longer lines, such as a long paragraph in one line of text, GitHub doesn't highlight the changes. When entering a suggestion for a long line, notice whether your changes are clearly highlighted. If the changes aren't highlighted, include comments outside the suggestion block explaining what you changed. Without an explanation it's often time-consuming for subsequent reviewers or the PR author to figure out what the changes are.
62+
GitHub lets you enter comments in triple-back-tick blocks of type `suggestion` that are displayed as a diff and can be merged by clicking a button. When entering a suggestion, include comments outside the suggestion block explaining what you changed. Without an explanation it's often time-consuming for subsequent reviewers or the PR author to figure out what the changes are.
6363

6464
## Respond to reviews
6565

Contribute/content/dotnet/dotnet-style-guide.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: This article contains a handy template you can use to create new ar
44
ms.topic: contributor-guide
55
ms.service: learn
66
ms.custom: external-contributor-guide
7-
ms.date: 11/07/2018
7+
ms.date: 06/17/2025
88
---
99
# Metadata and Markdown template for .NET docs
1010

@@ -48,12 +48,12 @@ Markdown uses special characters such as \*, \`, and \# for formatting. If you w
4848

4949
File names use the following rules:
5050

51-
* Contain only lowercase letters, numbers, and hyphens.
52-
* No spaces or punctuation characters. Use the hyphens to separate words and numbers in the file name.
53-
* Use action verbs that are specific, such as develop, buy, build, troubleshoot. No -ing words.
54-
* No small words - don't include a, and, the, in, or, etc.
55-
* Must be in Markdown and use the .md file extension.
56-
* Keep file names reasonably short. They are part of the URL for your articles.
51+
- Contain only lowercase letters, numbers, and hyphens.
52+
- No spaces or punctuation characters. Use the hyphens to separate words and numbers in the file name.
53+
- Use action verbs that are specific, such as develop, buy, build, troubleshoot. No -ing words.
54+
- No small words - don't include a, and, the, in, or, etc.
55+
- Must be in Markdown and use the .md file extension.
56+
- Keep file names reasonably short. They are part of the URL for your articles.
5757

5858
## Headings
5959

@@ -113,8 +113,6 @@ Examples:
113113
- System.Exception.\#ctor becomes `System.Exception.%23ctor`
114114
- System.Lazy\`1.\#ctor(System.Threading.LazyThreadSafetyMode) becomes `System.Lazy%601.%23ctor%28System.Threading.LazyThreadSafetyMode%29`
115115

116-
You can find the UIDs of types, a member overload list, or a particular overloaded member from `https://xref.learn.microsoft.com/autocomplete`. The query string `?text=*\<type-member-name>*` identifies the type or member whose UIDs you'd like to see. For example, `https://xref.learn.microsoft.com/autocomplete?text=string.format` retrieves the [String.Format](/dotnet/api/system.string.format) overloads. The tool searches for the provided `text` query parameter in any part of the UID. For example, you can search for member name (ToString), partial member name (ToStri), type and member name (Double.ToString), etc.
117-
118116
If you add a \* (or `%2A`) after the UID, the link then represents the overload page and not a specific API. For example, you can use that when you want to link to the [List\<T>.BinarySearch Method](/dotnet/api/system.collections.generic.list-1.binarysearch) page in a generic way instead of a specific overload such as [List\<T>.BinarySearch(T, IComparer\<T>)](/dotnet/api/system.collections.generic.list-1.binarysearch#System_Collections_Generic_List_1_BinarySearch__0_). You can also use \* to link to a member page when the member is not overloaded; this saves you from having to include the parameter list in the UID.
119117

120118
To link to a specific method overload, you must include the fully qualified type name of each of the method's parameters. For example, \<xref:System.DateTime.ToString> links to the parameterless [DateTime.ToString](/dotnet/api/system.datetime.tostring#System_DateTime_ToString) method, while \<xref:System.DateTime.ToString(System.String,System.IFormatProvider)> links to the [DateTime.ToString(String,IFormatProvider)](/dotnet/api/system.datetime.tostring#System_DateTime_ToString_System_String_System_IFormatProvider_) method.
@@ -167,21 +165,23 @@ A custom style is available for lists. You can render lists with green check mar
167165

168166
```markdown
169167
> [!div class="checklist"]
170-
> * How to create a .NET Core app
171-
> * How to add a reference to the Microsoft.XmlSerializer.Generator package
172-
> * How to edit your MyApp.csproj to add dependencies
173-
> * How to add a class and an XmlSerializer
174-
> * How to build and run the application
168+
>
169+
> - How to create a .NET Core app
170+
> - How to add a reference to the Microsoft.XmlSerializer.Generator package
171+
> - How to edit your MyApp.csproj to add dependencies
172+
> - How to add a class and an XmlSerializer
173+
> - How to build and run the application
175174
```
176175

177176
This renders as:
178177

179178
> [!div class="checklist"]
180-
> * How to create a .NET Core app
181-
> * How to add a reference to the Microsoft.XmlSerializer.Generator package
182-
> * How to edit your MyApp.csproj to add dependencies
183-
> * How to add a class and an XmlSerializer
184-
> * How to build and run the application
179+
>
180+
> - How to create a .NET Core app
181+
> - How to add a reference to the Microsoft.XmlSerializer.Generator package
182+
> - How to edit your MyApp.csproj to add dependencies
183+
> - How to add a class and an XmlSerializer
184+
> - How to build and run the application
185185
186186
You can see an example of checked lists in action in the [.NET Core docs](/dotnet/core/additional-tools/xml-serializer-generator).
187187

Contribute/content/dotnet/dotnet-voice-tone.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: Learn our voice and tone guidelines through examples of our styles
44
ms.topic: contributor-guide
55
ms.service: learn
66
ms.custom: external-contributor-guide
7-
ms.date: 11/07/2018
7+
ms.date: 06/17/2025
88
---
99
# Voice and tone guidelines
1010

0 commit comments

Comments
 (0)