Skip to content

Conversation

@m4tthumphrey
Copy link
Contributor

Add parameters parameter to put()

@stloyd
Copy link
Contributor

stloyd commented Nov 5, 2012

Hey,

First of all, thanks for interest.

But could you split those changes into separated PRs ? I can understand purposes for changes in: Github\Api\Repo (as well as I believe even more that I should created additional class for this part of API). But I don't any real use case for GitHub\HttpClient\HttpClient#put() parameters.

@m4tthumphrey
Copy link
Contributor Author

I did try but it automatically appends the previous PR.

This PUT method requires params: http://developer.github.com/v3/pulls/#merge-a-pull-request-merge-buttontrade

stloyd added a commit that referenced this pull request Nov 6, 2012
No option to create a repository for an organization
@stloyd stloyd merged commit 0df9f48 into KnpLabs:master Nov 6, 2012
@stloyd
Copy link
Contributor

stloyd commented Nov 6, 2012

Merged thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants