improve errors

Author: tanner0101

Sources/PostgresNIO/Connection/PostgresClient+Query.swift

@@ -21,6 +21,7 @@ private final class PostgresParameterizedQuery: PostgresRequest {
     var onRow: (PostgresRow) throws -> ()
     var rowLookupTable: PostgresRow.LookupTable?
     var resultFormatCodes: [PostgresFormatCode]
+    var logger: Logger?
 
     init(
         query: String,
@@ -34,6 +35,7 @@ private final class PostgresParameterizedQuery: PostgresRequest {
     }
 
     func log(to logger: Logger) {
+        self.logger = logger
         logger.debug("\(self.query) \(self.binds)")
     }
 
@@ -63,6 +65,16 @@ private final class PostgresParameterizedQuery: PostgresRequest {
         case .parseComplete:
             return []
         case .parameterDescription:
+//            let params = try PostgresMessage.ParameterDescription(message: message)
+//            if params.dataTypes.count != binds.count {
+//                self.logger!.warning("Expected parameters count (\(params.dataTypes.count)) does not equal binds count (\(binds.count))")
+//            } else {
+//                for (i, item) in zip(params.dataTypes, binds).enumerated() {
+//                    if item.0 != item.1.type {
+//                        self.logger!.warning("bind $\(i + 1) type (\(item.1.type)) does not match expected parameter type (\(item.0))")
+//                    }
+//                }
+//            }
             return []
         case .commandComplete:
             return []

Sources/PostgresNIO/Message/PostgresMessage+Error.swift

@@ -2,7 +2,7 @@ import NIO
 
 extension PostgresMessage {
     /// First message sent from the frontend during startup.
-    public struct Error: PostgresMessageType {
+    public struct Error: PostgresMessageType, CustomStringConvertible {
         public static var identifier: PostgresMessage.Identifier {
             return .error
         }
@@ -102,7 +102,9 @@ extension PostgresMessage {
 
         /// See `CustomStringConvertible`.
         public var description: String {
-            return (fields[.severity] ?? "ERROR") + ": " + (fields[.message] ?? "unknown")
+            let unique = self.fields[.routine] ?? self.fields[.sqlState] ?? "unknown"
+            let message = self.fields[.message] ?? "Unknown"
+            return "\(message) (\(unique))"
         }
     }
 }

Sources/PostgresNIO/Message/PostgresMessage+ParameterDescription.swift

@@ -2,7 +2,7 @@ import NIO
 
 extension PostgresMessage {
     /// Identifies the message as a parameter description.
-    public struct ParameterDescription {
+    public struct ParameterDescription: PostgresMessageType {
         /// Parses an instance of this message type from a byte buffer.
         public static func parse(from buffer: inout ByteBuffer) throws -> ParameterDescription {
             guard let dataTypes = try buffer.read(array: PostgresDataType.self, { buffer in

Sources/PostgresNIO/Utilities/PostgresError.swift

@@ -16,10 +16,7 @@ public enum PostgresError: Error, LocalizedError, CustomStringConvertible {
         switch self {
         case .protocol(let message): description = "protocol error: \(message)"
         case .server(let error):
-            let severity = error.fields[.severity] ?? "ERROR"
-            let unique = error.fields[.routine] ?? error.fields[.sqlState] ?? "unknown"
-            let message = error.fields[.message] ?? "Unknown"
-            description = "server \(severity.lowercased()): \(message) (\(unique))"
+            return "server: \(error.description)"
         case .connectionClosed:
             description = "connection closed"
         }