fix: Fixed inappropriate values for subnets and security_groups in example (terraform-aws-modules#63)

Hamza-Aziz · web-flow · commit fd7a25b4c995 · 2022-09-21T12:17:09.000+02:00
diff --git a/examples/with-ecs-scheduling/main.tf b/examples/with-ecs-scheduling/main.tf
@@ -63,8 +63,8 @@ module "eventbridge" {
 
           network_configuration = {
             assign_public_ip = true
-            subnets          = data.aws_subnet_ids.default
-            security_groups  = data.aws_security_group.default
+            subnets          = data.aws_subnet_ids.default.ids
+            security_groups  = [data.aws_security_group.default.arn]
           }
         }
       }
@@ -89,7 +89,6 @@ resource "aws_ecs_service" "hello_world" {
   name            = "hello_world-${random_pet.this.id}"
   cluster         = module.ecs.ecs_cluster_id
   task_definition = aws_ecs_task_definition.hello_world.arn
-  launch_type     = "FARGATE"
 
   desired_count = 1
 

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,8 @@ module "eventbridge" {`
`63`	`63`
`64`	`64`	`network_configuration = {`
`65`	`65`	`assign_public_ip = true`
`66`		`- subnets = data.aws_subnet_ids.default`
`67`		`- security_groups = data.aws_security_group.default`
	`66`	`+ subnets = data.aws_subnet_ids.default.ids`
	`67`	`+ security_groups = [data.aws_security_group.default.arn]`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`	`}`
`@@ -89,7 +89,6 @@ resource "aws_ecs_service" "hello_world" {`
`89`	`89`	`name = "hello_world-${random_pet.this.id}"`
`90`	`90`	`cluster = module.ecs.ecs_cluster_id`
`91`	`91`	`task_definition = aws_ecs_task_definition.hello_world.arn`
`92`		`- launch_type = "FARGATE"`
`93`	`92`
`94`	`93`	`desired_count = 1`
`95`	`94`