Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaComputing/DataSets.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: JuliaComputing/DataSets.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cjf/dataset-mutation-2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 8 files changed
  • 1 contributor

Commits on May 27, 2022

  1. DataSet create/delete + storage driver API changes

    * For data projects:
      - create() to create datasets
      - setindex!() to add existing datasets
      - delete() to delete datasets
      - Implementations for StackedDataProject, AbstractTOMLDataProject and TOMLDataProject
    
    * Concrete save_project() API to persist a DataProject to a file as TOML
    
    * For storage drivers:
      - AbstractDataDriver and implementation for FileSystemDriver
      - open_dataset to do what the current function-based API does
      - create_storage to initialize storage
      - delete_storage to remove storage
      - These ideas seem a bit half-baked
    
    * Refactoring open() to add write=true keyword
    c42f committed May 27, 2022
    Configuration menu
    Copy the full SHA
    2208e4f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Rename delete -> delete! and create -> create!

    Fix save_project for delete and create
    c42f committed May 30, 2022
    Configuration menu
    Copy the full SHA
    c3769be View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Configuration menu
    Copy the full SHA
    c895b4f View commit details
    Browse the repository at this point in the history
Loading