Skip to content

Commit aedd054

Browse files
committed
Fix items found in first code review comments
- remove @testable - remove SQLCipher references in docs - add deployment target to pod spec - merge recent master changes
2 parents 1ae2063 + 4a0fa9c commit aedd054

18 files changed

+17
-69
lines changed

Documentation/Index.md

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
- [Carthage](#carthage)
55
- [CocoaPods](#cocoapods)
66
- [Manual](#manual)
7-
- [SQLCipher](#sqlcipher)
87
- [Frameworkless Targets](#frameworkless-targets)
98
- [Getting Started](#getting-started)
109
- [Connecting to a Database](#connecting-to-a-database)
@@ -103,10 +102,6 @@ install SQLite.swift with Carthage:
103102
104103
pod 'SQLite.swift',
105104
git: 'https://github.com/stephencelis/SQLite.swift.git'
106-
107-
# instead, for SQLCipher support
108-
pod 'SQLiteCipher.swift',
109-
git: 'https://github.com/stephencelis/SQLite.swift.git'
110105
```
111106
112107
3. Run `pod install`.
@@ -132,22 +127,6 @@ To install SQLite.swift as an Xcode sub-project:
132127
You should now be able to `import SQLite` from any of your target’s source files and begin using SQLite.swift.
133128
134129
135-
#### SQLCipher
136-
137-
> _Note_: To install with CocoaPods, [see above](#cocoapods).
138-
139-
To install SQLite.swift with [SQLCipher](http://sqlcipher.net) support:
140-
141-
1. Make sure the **sqlcipher** working copy is checked out in Xcode. If **sqlcipher.xcodeproj** is unavailable (_i.e._, it appears red), go to the **Source Control** menu and select **Check Out sqlcipher…** from the **sqlcipher** menu item.
142-
143-
2. Follow [the instructions above](#manual) with the **SQLiteCipher** target, instead.
144-
145-
> _Note:_ By default, SQLCipher compiles [without support for full-text search](https://github.com/sqlcipher/sqlcipher/issues/102). If you intend to use [FTS4](#full-text-search), make sure you add the following to **Other C Flags** in the **Build Settings** of the **sqlcipher** target (in the **sqlcipher.xcodeproj** project):
146-
>
147-
> - `-DSQLITE_ENABLE_FTS4`
148-
> - `-DSQLITE_ENABLE_FTS3_PARENTHESIS`
149-
150-
151130
### Frameworkless Targets
152131
153132
It’s possible to use SQLite.swift in a target that doesn’t support frameworks, including iOS 7 apps and OS X command line tools, though it takes a little extra work.

README.md

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ syntax _and_ intent.
2121
- A lightweight, uncomplicated query and parameter binding interface
2222
- Developer-friendly error handling and debugging
2323
- [Full-text search][] support
24-
- [SQLCipher](#sqlcipher) support
2524
- [Well-documented][See Documentation]
2625
- Extensively tested
26+
- SQLCipher support will be available again soon (see #311)
2727

2828
[Full-text search]: Documentation/Index.md#full-text-search
2929
[See Documentation]: Documentation/Index.md#sqliteswift-documentation
@@ -150,10 +150,6 @@ SQLite.swift with CocoaPods:
150150
151151
pod 'SQLite.swift',
152152
git: 'https://github.com/stephencelis/SQLite.swift.git'
153-
154-
# instead, for SQLCipher support
155-
pod 'SQLiteCipher.swift',
156-
git: 'https://github.com/stephencelis/SQLite.swift.git'
157153
```
158154
159155
3. Run `pod install`.
@@ -184,33 +180,6 @@ To install SQLite.swift as an Xcode sub-project:
184180
[download]: https://github.com/stephencelis/SQLite.swift/archive/master.zip
185181
186182
187-
#### SQLCipher
188-
189-
> _Note_: To install with CocoaPods, [see above](#cocoapods).
190-
191-
To install SQLite.swift with [SQLCipher][] support:
192-
193-
1. Make sure the **sqlcipher** working copy is checked out in Xcode. If
194-
**sqlcipher.xcodeproj** is unavailable (_i.e._, it appears red), go to the
195-
**Source Control** menu and select **Check Out sqlcipher…** from the
196-
**sqlcipher** menu item.
197-
198-
2. Follow [the instructions above](#manual) with the **SQLiteCipher** target,
199-
instead.
200-
201-
> _Note:_ By default, SQLCipher compiles [without support for full-text
202-
> search][]. If you intend to use [FTS4][], make sure you add the
203-
> following to **Other C Flags** in the **Build Settings** of the
204-
> **sqlcipher** target (in the **sqlcipher.xcodeproj** project):
205-
>
206-
> - `-DSQLITE_ENABLE_FTS4`
207-
> - `-DSQLITE_ENABLE_FTS3_PARENTHESIS`
208-
209-
[SQLCipher]: http://sqlcipher.net
210-
[without support for full-text search]: https://github.com/sqlcipher/sqlcipher/issues/102
211-
[FTS4]: http://www.sqlite.org/fts3.html
212-
213-
214183
## Communication
215184
216185
[Read the contributing guidelines][]. The _TL;DR_ (but please; _R_):

SQLite.swift.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ Pod::Spec.new do |s|
2121

2222
s.module_name = 'SQLite'
2323
s.module_map = 'module.modulemap'
24+
s.ios.deployment_target = "8.0"
2425

2526
s.source_files = 'SQLite/**/*'
2627

SQLiteTests/AggregateFunctionsTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XCTest
2-
@testable import SQLite
2+
import SQLite
33

44
class AggregateFunctionsTests : XCTestCase {
55

SQLiteTests/BlobTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XCTest
2-
@testable import SQLite
2+
import SQLite
33

44
class BlobTests : XCTestCase {
55

SQLiteTests/ConnectionTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XCTest
2-
@testable import SQLite
2+
import SQLite
33

44
class ConnectionTests : SQLiteTestCase {
55

SQLiteTests/CoreFunctionsTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XCTest
2-
@testable import SQLite
2+
import SQLite
33

44
class CoreFunctionsTests : XCTestCase {
55

SQLiteTests/CustomFunctionsTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XCTest
2-
@testable import SQLite
2+
import SQLite
33

44
class CustomFunctionsTests : XCTestCase {
55

SQLiteTests/ExpressionTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XCTest
2-
@testable import SQLite
2+
import SQLite
33

44
class ExpressionTests : XCTestCase {
55

SQLiteTests/FTS4Tests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import XCTest
2-
@testable import SQLite
2+
import SQLite
33

44
class FTS4Tests : XCTestCase {
55

0 commit comments

Comments
 (0)